Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests not executed in CI anymore #120

Closed
echoix opened this issue Apr 11, 2023 · 8 comments
Closed

Tests not executed in CI anymore #120

echoix opened this issue Apr 11, 2023 · 8 comments

Comments

@echoix
Copy link

echoix commented Apr 11, 2023

Describe the bug
With the newest activity on the repo today (good sign!) I observed that the tests aren't being ran in CI as checks.

The tests seem to be run as part of an Azure Pipeline, but the last time a commit included this check was in 9db3c14 (November 21, 2022)

No test steps seem to be configured in the main.yml workflow.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://github.com/microsoft/XamlBehaviorsWpf/commits/master
  2. Click on a green check or red x after a commit to look at the checks status for a commit. Choose one on April 10, 2023, and one on November 21, 2022.
  3. Scroll down to look for a Azure Pipelines check.
  4. See that the commits on April 10, 2023 don't include an Azure Pipelines check.

Expected behavior
Either work on enabling back the Azure Pipelines (but external contributors can't monitor it without having appropriate login credentials), or modernize the GitHub Actions workflow to build and test at the same time.

Screenshots
If applicable, add screenshots to help explain your problem.

Commit 7678354 doesn't have tests ran.
image
image

Desktop (please complete the following information):

  • Version with bug: 7678354 and later
  • Last known working version: 9db3c14

Reproduction Link

@brianlagunas
Copy link
Collaborator

Wow, great catch. Unfortunately I don’t have access to any of the DevOps infrastructure. Hopefully @mgoertz-msft can look into this for us.

I do have another PR in the works so it would be nice to get our tests running with CI again.

@echoix
Copy link
Author

echoix commented Apr 11, 2023

I was surprised to have a email notification of an update on the repo, I had enabled them since I was using it and had some usability bugs/irritations when using it with VS2022, but the repo has been very quiet for a long time.

But either way, if you aren't experienced with Actions, there is always this to help out: https://docs.github.com/en/actions/migrating-to-github-actions/automated-migrations/automating-migration-with-github-actions-importer,
but there might be some better patterns with dotnet projects now than a port of a three years old Azure Pipeline.

@brianlagunas
Copy link
Collaborator

Actually, I didn’t realize this repo was using GitHub actions. I was never made aware of that change. I’m familiar with GitHub actions and should be able to help out there too.

@brianlagunas
Copy link
Collaborator

It’s confusing because I see Azure Pipelines AND GitHub Actions in this repo.

@echoix
Copy link
Author

echoix commented Apr 11, 2023

It’s confusing because I see Azure Pipelines AND GitHub Actions in this repo.

But it's not a problem, you can always use the best tool for a job, and if it means using Azure Pipelines and GitHub Actions, and any other, it isn't a problem, and each can run independently.

@mgoertz-msft
Copy link
Member

Right, we use the AzDO pipeline for publishing a release to NuGet.org because it runs a bunch of compliance checks. It doesn't run any unit tests though but perhaps that's better done through the publicly visible GH actions anyway.

It looks like we used to run the same AzDO pipeline for CI builds as well, but it's turned off now. I'll have to see how to continue running it for CI and PR builds without accidentally publishing a package. Let me know if you disagree @brianlagunas but I think we want to keep the publishing of a release a manual process instead of simply doing it for every green CI build.

@brianlagunas
Copy link
Collaborator

Yes, publishing a release should definitely be a manual process. For now, we can just add the unit tests to the GitHub Actions. This will help ensure a breaking change is less likely to be introduced via a PR. However, ideally, the release build would also run unit tests.

@brianlagunas
Copy link
Collaborator

Tests have been added to the GitHub Actions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants