Finish NSFileHandle's stubbed methods #2477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit marks roughly half of NSFileHandle's APIs NotInPlan. WinSock deals in opaque handles which cannot be used with open/close/seek/tell/read/write, so most of NSFileHandle's APIs cannot be supported with the POSIX File Descriptor interface. The background APIs are better suited to use with a socket than with a file, so until somebody asks for socket support, we will mark them unplanned. File handles cannot be coded except through IPC coders, but WinObjC does not have any IPC coders. Fixes microsoft#2367.
DHowett-MSFT
commented
Apr 10, 2017
| } | ||
|
|
||
| /** | ||
| @Status Interoperable | ||
| */ | ||
| + (NSFileHandle*)fileHandleWithNullDevice { | ||
| return [[_NSFileHandleNullDevice new] autorelease]; | ||
| static StrongId<NSFileHandle> nullDeviceHandle{ woc::TakeOwnership, [_NSFileHandleNullDevice new] }; |
There was a problem hiding this comment.
TakeOwnership LIIIIIIVESSSSSSSSS
aballway
approved these changes
Apr 10, 2017
| @Status Caveat | ||
| @Notes NSFileHandle only supports file URLs. | ||
| */ | ||
| + (instancetype)fileHandleForReadingFromURL:(NSURL*)url error:(NSError* _Nullable*)error { | ||
| return [NSFileHandle _fileHandleForURl:url error:error openType:_NSFileOpenModeRead]; | ||
| return [NSFileHandle _fileHandleForURL:url error:error openType:_NSFileOpenModeRead]; |
| if (file == nil) { | ||
| [self release]; | ||
| return nil; | ||
| } |
There was a problem hiding this comment.
nit: empty space after curly brace.
| _SH_DENYNO, | ||
| _S_IREAD | _S_IWRITE); | ||
| default: | ||
| break; |
There was a problem hiding this comment.
Since this is internal, should we fail if we get an invalid type?
| - (void)waitForDataInBackgroundAndNotifyForModes:(NSArray*)modes STUB_METHOD; | ||
| @property (readonly) int fileDescriptor; | ||
| @property (readonly, copy) NSData* availableData; | ||
| @property (readonly) unsigned long long offsetInFile; |
There was a problem hiding this comment.
super duper ultra nit: no implied int
rajsesh
suggested changes
Apr 10, 2017
| @@ -28,6 +28,10 @@ | |||
| NSString* const NSFileHandleNotificationDataItem = @"NSFileHandleNotificationDataItem"; | |||
| NSString* const NSFileHandleOperationException = @"NSFileHandleOperationException"; | |||
| NSString* const NSFileHandleNotificationMonitorModes = @"NSFileHandleNotificationMonitorModes"; | |||
| NSString* const NSFileHandleConnectionAcceptedNotification = @"NSFileHandleConnectionAccepted"; | |||
There was a problem hiding this comment.
Do we want to "fix" these strings if they are not the right values already?
| @@ -175,37 +121,103 @@ + (instancetype)fileHandleForUpdatingAtPath:(NSString*)file { | |||
| } | |||
|
|
|||
| /** | |||
| @Status Stub | |||
| @Notes | |||
| @Status Caveat | |||
There was a problem hiding this comment.
The header file must be updated too, to remove the STUB_* macros (and add NOTINPLAN_* macros where applicable.
There was a problem hiding this comment.
Ugh I can't see things today, my bad :(
rajsesh
approved these changes
Apr 10, 2017
| @@ -175,37 +121,103 @@ + (instancetype)fileHandleForUpdatingAtPath:(NSString*)file { | |||
| } | |||
|
|
|||
| /** | |||
| @Status Stub | |||
| @Notes | |||
| @Status Caveat | |||
There was a problem hiding this comment.
Ugh I can't see things today, my bad :(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit marks roughly half of NSFileHandle's APIs NotInPlan.
WinSock deals in opaque handles which cannot be used with
open/close/seek/tell/read/write, so most of NSFileHandle's APIs cannot
be supported with the POSIX File Descriptor interface.
The background APIs are better suited to use with a socket than with a
file, so until somebody asks for socket support, we will mark them
unplanned.
File handles cannot be coded except through IPC coders, but WinObjC does
not have any IPC coders.
Fixes #2367.