From aa26d690e498292c5e063130dca9c0a32bbc0339 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 19 Mar 2024 11:32:51 -0700 Subject: [PATCH 1/4] Print baseline diffs on test failures --- .github/workflows/ci.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 31a9b0261bbcf..325f4e2f6fa85 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -57,9 +57,14 @@ jobs: - run: npm ci - name: Tests + id: test # run tests, but lint separately run: npm run test -- --no-lint --bundle=${{ matrix.bundle }} + - name: Print baseline diff on failure + if: ${{ failure() && steps.test.conclusion == 'failure' }} + run: git diff --no-index -- ./tests/baselines/reference ./tests/baselines/local + lint: runs-on: ubuntu-latest From 9dce39e081161241a42b438b1988b794374b0999 Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 19 Mar 2024 11:43:11 -0700 Subject: [PATCH 2/4] revert me: make the tests fail --- tests/cases/compiler/2dArrays.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/cases/compiler/2dArrays.ts b/tests/cases/compiler/2dArrays.ts index 5a3dac3fff60e..4a2b72250cdb1 100644 --- a/tests/cases/compiler/2dArrays.ts +++ b/tests/cases/compiler/2dArrays.ts @@ -12,4 +12,6 @@ class Board { private allShipsSunk() { return this.ships.every(function (val) { return val.isSunk; }); } -} \ No newline at end of file +} + +console.log("revert me"); \ No newline at end of file From 718b4d54b4484f44f4dcb1c82abf02e1168b7a6e Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 19 Mar 2024 12:13:50 -0700 Subject: [PATCH 3/4] fix filter --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 325f4e2f6fa85..482950af8045b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -63,7 +63,7 @@ jobs: - name: Print baseline diff on failure if: ${{ failure() && steps.test.conclusion == 'failure' }} - run: git diff --no-index -- ./tests/baselines/reference ./tests/baselines/local + run: git diff --diff-filter=AM --no-index -- ./tests/baselines/reference ./tests/baselines/local lint: runs-on: ubuntu-latest From bffff130167c80757208112a100e17cf952855cb Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 19 Mar 2024 12:21:05 -0700 Subject: [PATCH 4/4] Revert "revert me: make the tests fail" This reverts commit 9dce39e081161241a42b438b1988b794374b0999. --- tests/cases/compiler/2dArrays.ts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/cases/compiler/2dArrays.ts b/tests/cases/compiler/2dArrays.ts index 4a2b72250cdb1..5a3dac3fff60e 100644 --- a/tests/cases/compiler/2dArrays.ts +++ b/tests/cases/compiler/2dArrays.ts @@ -12,6 +12,4 @@ class Board { private allShipsSunk() { return this.ships.every(function (val) { return val.isSunk; }); } -} - -console.log("revert me"); \ No newline at end of file +} \ No newline at end of file