Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TSServer shouldn't assume that OSX file system in case insensitive #8139

Closed
dbaeumer opened this issue Apr 18, 2016 · 8 comments
Closed

TSServer shouldn't assume that OSX file system in case insensitive #8139

dbaeumer opened this issue Apr 18, 2016 · 8 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@dbaeumer
Copy link
Member

TypeScript Version:

1.8.9

The tsserver code assumes that OSX file systems are always run case insensitive. However this is not the case. When the tsserver is used on a case sensitive file system code assist and other features stop working do to file lookup misses. For all the details please see:

microsoft/vscode#5161 (comment)

@billti
Copy link
Member

billti commented Apr 18, 2016

@zhengbli aren't you already looking into this for other issues related to watchers?

@zhengbli
Copy link
Contributor

This should be fixed by #7658, which was merged in master.

@otbe
Copy link

otbe commented Apr 19, 2016

Tried to use 1.9.0-dev.20160419 with vscode and in my test project, but got TypeError: service.getSourceFile is not a function from gulp-tsb.

Is it possible to test your fix?

@vladima
Copy link
Contributor

vladima commented Apr 19, 2016

it seems that gulp-tsb was not updated to work with the latest bits: outstanding PR to fix it jrieken/gulp-tsb#40

@zhengbli
Copy link
Contributor

@otbe currently you can test by editing your test project directly in vscode, with the nightly build of typescript.

@otbe
Copy link

otbe commented Apr 19, 2016

@zhengbli
Should I install 1.9.0-dev.20160419 as my project dependency?

@zhengbli
Copy link
Contributor

If you mean using it with VSCode, you could edit your settings file via File -> Preferences -> User Settings, and add

"typescript.tsdk": "<the folder where tsserver.js lives>"

for example

"typescript.tsdk": "C:/Program Files/nodejs/node_modules/typescript/lib",

@otbe
Copy link

otbe commented Apr 20, 2016

Works as expected.
Thank you 👍

@mhegazy mhegazy added this to the TypeScript 2.0 milestone Apr 20, 2016
@zhengbli zhengbli added the Fixed A PR has been merged for this issue label Apr 21, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

6 participants