Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unintended escaped string for hover #57539

Open
Hajime-san opened this issue Feb 26, 2024 · 4 comments Β· May be fixed by #57550
Open

unintended escaped string for hover #57539

Hajime-san opened this issue Feb 26, 2024 · 4 comments Β· May be fixed by #57550
Labels
Bug A bug in TypeScript Help Wanted You can do this
Milestone

Comments

@Hajime-san
Copy link

πŸ”Ž Search Terms

"lsp"

πŸ•— Version & Regression Information

version "typescript": "5.3.3"

⏯ Playground Link

No response

πŸ’» Code

// 🦁.ts
export const foo = "bar";

// main.ts
import { bar } from './🦁.ts';

πŸ™ Actual behavior

The lsp message shows Module '"./\uD83E\uDD81.ts"' has no exported member 'bar'.ts(2305).

πŸ™‚ Expected behavior

It should be Module '"./🦁.ts"' has no exported member 'bar'.ts(2305).

Additional information about the issue

γ‚Ήγ‚―γƒͺγƒΌγƒ³γ‚·γƒ§γƒƒγƒˆ 2024-02-26 10 11 39
@Andarist
Copy link
Contributor

This likely falls under the umbrella here (it's worked on here)

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this labels Feb 26, 2024
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Feb 26, 2024
@fatcerberus
Copy link

fatcerberus commented Feb 26, 2024

@Andarist Wait, is that even related? That looks like it's about arbitrary import names, e.g.

import { "😊" as yay } from "foo";

...which doesn't work at all today (i.e. it's a feature request), whereas this issue is about unicode characters in module specifiers, which does work today, the filename is just not being rendered property in error messages.

@Andarist
Copy link
Contributor

You are totally right. I'm trying to do to much lately and it seems my circuits are overheating :v

@Andarist
Copy link
Contributor

My penance: #57550

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants