Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NewErrors] 4.6.0-dev.20211205 vs 4.5.2 #47028

Closed
typescript-bot opened this issue Dec 5, 2021 · 1 comment · Fixed by #47125
Closed

[NewErrors] 4.6.0-dev.20211205 vs 4.5.2 #47028

typescript-bot opened this issue Dec 5, 2021 · 1 comment · Fixed by #47125
Assignees
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue

Comments

@typescript-bot
Copy link
Collaborator

The following errors were reported by 4.6.0-dev.20211205, but not by 4.5.2

microsoft/vscode

2 of 52 projects failed to build with the old tsc

src/tsconfig.json

src/tsconfig.tsec.json

lensapp/lens

4 of 5 projects failed to build with the old tsc

tsconfig.json

@RyanCavanaugh
Copy link
Member

VS Code break:

interface DatafulFoo<T> {
    data: T;
}

class Foo<T extends string> {
    data: T | undefined;

    bar() {
        if (this.hasData()) {
            this.data.toLocaleLowerCase();
        }
    }

    hasData(): this is DatafulFoo<T> {
        return true;
    }
}

@RyanCavanaugh RyanCavanaugh added this to the TypeScript 4.6.0 milestone Dec 7, 2021
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Dec 7, 2021
@typescript-bot typescript-bot added the Fix Available A PR has been opened for this issue label Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Fix Available A PR has been opened for this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants