Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fuzzer, Drive Fuzzer Bugs to Zero, Expand Fuzzer Functions #44210

Closed
2 of 4 tasks
DanielRosenwasser opened this issue May 21, 2021 · 6 comments
Closed
2 of 4 tasks
Labels
Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@DanielRosenwasser
Copy link
Member

DanielRosenwasser commented May 21, 2021

We have a (currently) private fuzzer which simply opens OSS projects on GitHub, runs some language server operations on a project, and finds crashes. This helps pinpoint stability issues in TypeScript and the server so that we can improve reliability. This issue tracks a few things:

  • Improving the fuzzer infrastructure: we believe that the codebase could benefit from some clean-up
  • Expanding the fuzzer to work on TypeScript files
  • Fixing crashes found by the fuzzer: there's a couple at the time of writing, and we want to drive them down to 0
  • Expanding functionality of the fuzzer: we want to start performing more involved operations to proactively catch issues
@DanielRosenwasser
Copy link
Member Author

I've added one bullet point around broadening the fuzzer to work on TypeScript files; it appears we only work on JS files.

@elibarzilay
Copy link
Contributor

There is currently only one open issue (microsoft/tsserverfuzzer#263) which we couldn't reproduce in any way (including asking the person who replied to the linked TS issue, #39584). So I checked that box.

@andrewbranch andrewbranch added the Rescheduled This issue was previously scheduled to an earlier milestone label Aug 30, 2021
@DanielRosenwasser
Copy link
Member Author

Can we say this is closed out? What is left for this one?

Expanding functionality of the fuzzer: we want to start performing more involved operations to proactively catch issues

@DanielRosenwasser
Copy link
Member Author

I suppose now that we've expanded the fuzzer, we should uncheck

Fixing crashes found by the fuzzer: there's a couple at the time of writing, and we want to drive them down to 0

@gabritto
Copy link
Member

Can we say this is closed out? What is left for this one?

Expanding functionality of the fuzzer: we want to start performing more involved operations to proactively catch issues

We still haven't added new tsserver commands to the fuzzer. The last thing I did was to go through the commands already there and make sure they were configured right.

@gabritto
Copy link
Member

@DanielRosenwasser @amcasey can we close this since Andrew is rewriting the fuzzer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Development

No branches or pull requests

5 participants