Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update downlevel-dts for tuple enhancements in 4.0 #39099

Closed
RyanCavanaugh opened this issue Jun 16, 2020 · 2 comments · Fixed by sandersn/downlevel-dts#38
Closed

Update downlevel-dts for tuple enhancements in 4.0 #39099

RyanCavanaugh opened this issue Jun 16, 2020 · 2 comments · Fixed by sandersn/downlevel-dts#38
Assignees
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript

Comments

@RyanCavanaugh
Copy link
Member

  • Named tuple members (strip the names)
  • Variadic tuples (TODO: What do we need to cover?)
@jdmichaud
Copy link

I see you were not sure Variadic Typle Types were impacting older TS versions. Do you have a definitive answer on this? Did Variadic Tuples be managed by downlevel-dts? I don't see any change related to this in sandersn/downlevel-dts#38.

@sandersn
Copy link
Member

Variadic tuple types definitely do not work in older TS versions. But downlevel-dts is operates only on syntax, and converting a single signature with tuple kinds to a set of overload signature is extremely complex, even with semantic information.

Basically, users of downlevel-dts need to test the generated d.ts files to make sure that the downlevelled code is valid.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Experience Enhancement Noncontroversial enhancements Suggestion An idea for TypeScript
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants