Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

./.vscode > tasks.json contains deprecated API tasks.identifier #32665

Closed
nataliemarleny opened this issue Aug 1, 2019 · 1 comment
Closed
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Milestone

Comments

@nataliemarleny
Copy link

nataliemarleny commented Aug 1, 2019

TypeScript Version: 3.6.0

Search Terms:
vscode, tasks.json, tasks, identifier

Code
./.vscode > tasks.json contains deprecated API tasks.identifier.

    "tasks": [
        {
            "type": "shell",
            "identifier": "local", // deprecated
            "label": "gulp: local",
            "command": "gulp",
            "args": ["local"],
            "group": { "kind": "build", "isDefault": true },
            "problemMatcher": ["$gulp-tsc"]
        },

Note: tasks.identifier in tasks.json was introduced: 41567b2 - Migrate tscWatchMode to vfs

Expected behavior:

tasks.identifier should not be present in tasks.json

Reference: microsoft/vscode#57946
Further discussion see thread containing: microsoft/vscode#57707 (comment)
Schema for tasks.json: https://code.visualstudio.com/docs/editor/tasks-appendix

Actual behavior:
VSCode shows a warning for the identifier field

Suggested solution

Either:

  • Remove identifier as a parameter, (functionality is covered by label)

or

  • Remove ./.vscode > tasks.json if configured tasks no longer needed
  • Remove .gitignore reference:
    !**/.vscode/tasks.json

or

Playground Link:
Not applicable

Related Issues:
None found

@RyanCavanaugh RyanCavanaugh added the Infrastructure Issue relates to TypeScript team infrastructure label Aug 1, 2019
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Aug 1, 2019
@jakebailey
Copy link
Member

This is an old issue, but this was fixed in #35282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

3 participants