source.organizeImports organizes imports to a sort order that tslint complains about

[StephenWeatherford]

Issue Type: Bug

settings:
"editor.codeActionsOnSave": {
"source.fixAll": true,
"source.organizeImports": true
}
tslint.json:
{
"extends": "tslint-microsoft-contrib",
...

Code:

import * as cp from 'child_process';
import * as fse from 'fs-extra';
import { IActionContext, parseError } from 'vscode-azureextensionui';
import { ImageNode } from '../explorer/models/imageNode';
import { ext } from '../extensionVariables';
import { docker, DockerEngineType } from './utils/docker-endpoint';
import { ImageItem, quickPickImage } from './utils/quick-pick-image';
import os = require('os');
import vscode = require('vscode');

That gives this error:

Auto-fixing the lint issue reorders to this code:

import * as cp from 'child_process';
import * as fse from 'fs-extra';
import os = require('os');
import vscode = require('vscode');
import { IActionContext, parseError } from 'vscode-azureextensionui';
import { ImageNode } from '../explorer/models/imageNode';
import { ext } from '../extensionVariables';
import { docker, DockerEngineType } from './utils/docker-endpoint';
import { ImageItem, quickPickImage } from './utils/quick-pick-image';

Then pressing CTRL+S to save puts it back to the first form, which causes the lint error again.

VS Code version: Code - Insiders 1.33.0-insider (d77d8d561143cc021a82664efc056755c075d070, 2019-03-11T08:47:23.627Z)
OS version: Windows_NT x64 10.0.17763

System Info

Item	Value
CPUs	Intel(R) Xeon(R) W-2133 CPU @ 3.60GHz (12 x 3600)
GPU Status	2d_canvas: enabled checker_imaging: disabled_off flash_3d: enabled flash_stage3d: enabled flash_stage3d_baseline: enabled gpu_compositing: enabled multiple_raster_threads: enabled_on native_gpu_memory_buffers: disabled_software rasterization: enabled surface_synchronization: enabled_on video_decode: enabled webgl: enabled webgl2: enabled
Memory (System)	31.73GB (16.54GB free)
Process Argv
Screen Reader	no
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
vscode-antlr4	mik	2.1.1
vscode-cosmosdb	ms-	0.10.0
extension-manifest-editor	ms-	0.1.5
azure-account	ms-	0.8.0
csharp	ms-	1.17.1
vscode-typescript-tslint-plugin	ms-	1.0.0
azurerm-vscode-tools	msa	0.5.0
vscode-docker	Pet	0.5.2
vscode-sort-json	ric	1.13.0
scope-info	sie	0.2.0
tmcolor	sle	0.0.1
sort-lines	Tyr	1.8.0
win-ca	uko	2.4.0

[RyanCavanaugh]

I don't know what we're going to do when tslint and eslint disagree about import order, but someone can send a PR to tweak this order for now I guess

[felixfbecker]

ESLint is even worse, because it requires import * from imports to come before all cherry-picking imports

[chapmanjacobd]

also one issue is that

import './file'
import { normal } from 'stuff'
import './z-file-which-should-load-first'

will lead to incorrect sort order....

[jasonwilliams]

It would be really nice to be able to switch the ordering off, not everyone wants that but we do want to remove unused imports, i raised it here: #43141