Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested assignment declaration doesn't merge with imported symbol #29870

Closed
ArtyMaury opened this issue Feb 5, 2019 · 2 comments
Closed

Nested assignment declaration doesn't merge with imported symbol #29870

ArtyMaury opened this issue Feb 5, 2019 · 2 comments
Assignees
Labels
Bug A bug in TypeScript

Comments

@ArtyMaury
Copy link

Hi,
I was using axios, which includes typings. It worked well unitl I changed the value of an attribute.
Then I lost intellisense on the axios object.
Here are the screenshots to reproduce:

image

image

I tried with and without intellicode.
I don't know if it's due to typescript of vscode.

  • VSCode Version: 1.30.2
@mjbvz mjbvz self-assigned this Feb 5, 2019
@mjbvz mjbvz transferred this issue from microsoft/vscode Feb 12, 2019
@mjbvz
Copy link
Contributor

mjbvz commented Feb 12, 2019

I confirmed this with the example code:

// @ts-check
import a from 'axios';

a.defaults.x = 1;

This produces the error Import declaration conflicts with local declaration of 'a'.. After the assignment, a only has a default property:

screen shot 2019-02-11 at 5 26 05 pm

@mjbvz mjbvz removed their assignment Feb 12, 2019
@RyanCavanaugh RyanCavanaugh added the Bug A bug in TypeScript label Feb 14, 2019
@RyanCavanaugh RyanCavanaugh added this to the TypeScript 3.5.0 milestone Feb 14, 2019
@sandersn sandersn changed the title Losing typings after value change Nested assignment declaration doesn't merge with imported symbol May 20, 2019
@sandersn
Copy link
Member

sandersn commented Aug 5, 2019

Fixed by #32626

@sandersn sandersn closed this as completed Aug 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript
Projects
None yet
Development

No branches or pull requests

5 participants