Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assertion failure when combining insertNodeAfter with deleteNode #23793

Closed
ghost opened this issue Apr 30, 2018 · 0 comments
Closed

Assertion failure when combining insertNodeAfter with deleteNode #23793

ghost opened this issue Apr 30, 2018 · 0 comments
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue
Milestone
TypeScript 2.9

Comments

@ghost
Copy link

ghost commented Apr 30, 2018

TypeScript Version: master

Code

See comment in moveToNewFile_js.ts (as of #23726).
We are moving const y away, and also inserting a node after the previous statement. We can't simply use replaceNode since we don't know that these two changes will be related.
@ghost ghost added Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter labels Apr 30, 2018
@mhegazy mhegazy assigned ghost Apr 30, 2018
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Apr 30, 2018
@ghost ghost mentioned this issue May 2, 2018
Merged
@ghost ghost added the Fixed A PR has been merged for this issue label May 2, 2018
@mhegazy mhegazy closed this as completed May 10, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Bug A bug in TypeScript Domain: Formatter The issue relates to the built-in formatter Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.9
Development

No branches or pull requests
1 participant
@mhegazy