Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server/project: External files should be added to project root files map #21280

Closed
kyliau opened this issue Jan 18, 2018 · 2 comments
Closed

server/project: External files should be added to project root files map #21280

kyliau opened this issue Jan 18, 2018 · 2 comments
Assignees
@RyanCavanaugh
Labels
Bug A bug in TypeScript
Milestone
Backlog

Comments

@kyliau
Copy link
Contributor

kyliau commented Jan 18, 2018 •
edited
Loading

While testing the Angular language service using the plugin architecture, we encountered an issue where semantic errors are not shown on external Angular templates.

Adding the external files to the project rootFilesMap solved this issue. The proposed fix is here.
Could you please comment whether this is the right approach?

Related issue: #20321
@mhegazy
Copy link
Contributor

mhegazy commented Jan 18, 2018

@RyanCavanaugh can you help @kyliau out on this issue

@mhegazy mhegazy added the Bug A bug in TypeScript label Jan 18, 2018
@kyliau kyliau mentioned this issue Jan 18, 2018
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 2.8 milestone Jan 18, 2018
@kyliau kyliau changed the title server/project: Script info not updated if existing value is undefined server/project: External files should be added to project root files map Jan 19, 2018
@mhegazy mhegazy modified the milestones: TypeScript 2.8, TypeScript 2.9 Mar 9, 2018
@mhegazy mhegazy modified the milestones: TypeScript 3.0, Future Jul 2, 2018
@RyanCavanaugh
Copy link
Member

Not sure what this is and it seems like this must be resolved by now

@RyanCavanaugh RyanCavanaugh closed this as not planned Won't fix, can't repro, duplicate, stale Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RyanCavanaugh RyanCavanaugh

Labels
Bug A bug in TypeScript
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@DanielRosenwasser @kyliau @RyanCavanaugh @mhegazy