Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional comma separated interface member without type breaks highlighting #651

Closed
mjbvz opened this issue Aug 20, 2018 · 2 comments
Closed

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Aug 20, 2018

TS and JS Grammar Extension version: 0.0.43 / latest

From microsoft/vscode#56229

Code

interface DagEdge {
    id?
}
var a = 1;

Highlighting is broken after the interface declaratio

screen shot 2018-08-20 at 4 17 24 pm

@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 21, 2018

Duplicate of #643. Pulling in new grammar fixed this in VS Code

@mjbvz mjbvz closed this as completed Aug 21, 2018
@mjbvz
Copy link
Contributor Author

mjbvz commented Aug 21, 2018

Actually, going back to original vscode issue, this case is still broken:

interface DagEdge {
    a?,
    b
}
var a = 1;

@mjbvz mjbvz reopened this Aug 21, 2018
@mjbvz mjbvz changed the title Optional interface member without type breaks highlighting Optional comma separated interface member without type breaks highlighting Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant