Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P2549R1 unexpected<E>::error() #2940

Closed
2 of 3 tasks
StephanTLavavej opened this issue Jul 25, 2022 · 1 comment · Fixed by #3075
Closed
2 of 3 tasks

P2549R1 unexpected<E>::error() #2940

StephanTLavavej opened this issue Jul 25, 2022 · 1 comment · Fixed by #3075
Labels
cxx23 C++23 feature fixed Something works now, yay! good first issue Good for newcomers

Comments

@StephanTLavavej
Copy link
Member

StephanTLavavej commented Jul 25, 2022 •
edited by CaseyCarter
Loading

P2549R1 unexpected<E>::error()

It is unclear to me whether the editors will increase the value of __cpp_lib_expected when merging this paper.

@miscco speculatively implemented this as part of #2643, so I believe that all that remains to be done is:

  • Double-check that there are no normative differences between R0 and R1.
  • Find out what's happening with the feature-test macro.
  • Update this citation:

    STL/stl/inc/yvals_core.h

    Line 318 in 04ee878

    // P2549R0 unexpected<E>::error()
@StephanTLavavej StephanTLavavej added the cxx23 C++23 feature label Jul 25, 2022
@frederick-vs-ja
Copy link
Contributor

According to the corresponding editorial PR,

  • no normative differences are in R0 and R1, and
  • no feature-test macro is changed.

So this should be a "good first issue" and we may proceed in #2873?

@CaseyCarter CaseyCarter added the good first issue Good for newcomers label Aug 20, 2022
@killerswin2 killerswin2 mentioned this issue Sep 4, 2022
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx23 C++23 feature fixed Something works now, yay! good first issue Good for newcomers
Projects
STL C++23 Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

<yvals_core.h> Update P2549 to new revision killerswin2/STL
3 participants
@CaseyCarter @StephanTLavavej @frederick-vs-ja