Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON file formatted - FancyZones zones-setting.json #8080

Closed
DNM1008 opened this issue Nov 17, 2020 · 9 comments
Closed

JSON file formatted - FancyZones zones-setting.json #8080

DNM1008 opened this issue Nov 17, 2020 · 9 comments
Labels
FancyZones-Editor Issue revolving the FancyZone Editor FancyZones-Settings FancyZone setting issue Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@DNM1008
Copy link

DNM1008 commented Nov 17, 2020

📝 Provide a description of the new feature

What is the expected behavior of the proposed feature? What is the scenario this would be used?

I want the setting file to be written in lines, much like how the setting of the Terminal app, so that when we want to have a look at our settings and make pixel-presision zone settings, it's easier to read and manoeuvrer around the file without making mistakes here and there. I tried hitting the Enter key, but every time I came back it was the same, in a single line. I don't know the mechanism for resetting the file (while still keeping my settings, provided that I exit from PowerToys, mind you, which is great).
I'd ask for auto complete for syntaxes, say if you add another zone after the last, it automatically adds a comma, or ask for missing variable, stuff like that, but I guess that's a plugin thing that I have to install on VSCode.


If you'd like to see this feature implemented, add a 👍 reaction to this post.

@ghost ghost added the Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams label Nov 17, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

This is your problem?

powertoys-settings json

I made this GIF a few weeks ago to create a new issue but you did that for me

@ghost ghost added the Product-Settings The standalone PowerToys Settings application label Nov 17, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

You can press Ctrl+Shift+P and type in "Format Document"

@DNM1008
Copy link
Author

DNM1008 commented Nov 17, 2020

You can press Ctrl+Shift+P and type in "Format Document"

I'll try that, thank you

@DNM1008 DNM1008 closed this as completed Nov 17, 2020
@ghost ghost reopened this Nov 17, 2020
@ghost
Copy link

ghost commented Nov 17, 2020

This should be a request to keep the JSON files formatted

@crutkas crutkas added Priority-3 Bug that is low priority and removed Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Nov 17, 2020
@crutkas crutkas changed the title Multiple lines in FancyZones zones-setting.json JSON file formatted - FancyZones zones-setting.json Nov 17, 2020
@crutkas
Copy link
Member

crutkas commented Nov 17, 2020

I'd like to warn that you're dealing with stuff that typically is set by an app and this is unsupported to hand edit

@DNM1008
Copy link
Author

DNM1008 commented Nov 17, 2020 via email

@crutkas
Copy link
Member

crutkas commented Nov 17, 2020

we were looking to do this for some of the v2 editor adjustments. #1032 is the tracking issue

@ghost
Copy link

ghost commented Nov 18, 2020

What about the JSON for PowerToys Settings

@enricogior enricogior added FancyZones-Settings FancyZone setting issue Product-Settings The standalone PowerToys Settings application and removed Product-Settings The standalone PowerToys Settings application labels Nov 18, 2020
@ghost ghost added the FancyZones-Editor Issue revolving the FancyZone Editor label Nov 18, 2020
@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Jan 27, 2021
@enricogior
Copy link
Contributor

Fixed by #9325

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Editor Issue revolving the FancyZone Editor FancyZones-Settings FancyZone setting issue Priority-3 Bug that is low priority Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

3 participants