Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FZ Editor] No way to create a custom grid layout #582

Closed
Defman21 opened this issue Oct 29, 2019 · 10 comments
Closed

[FZ Editor] No way to create a custom grid layout #582

Defman21 opened this issue Oct 29, 2019 · 10 comments
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Issue-Docs Documentation issue that needs to be improved Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.

Comments

@Defman21
Copy link

Summary of the new feature/enhancement

There's no way to create a grid layout in the Custom tab. Editing the "Create new custom" opens the "custom layout" creator and I didn't find a way to open the "custom table layout" creator except for editing a template.

@bzoz
Copy link
Contributor

bzoz commented Oct 30, 2019

As I understand correctly: you want to adjust the default gird layout in the editor, not start from scratch?

@Defman21
Copy link
Author

Defman21 commented Oct 30, 2019

I actually want to start from scratch, so I'd have one big layout that I'd split manually. There are some pre-defined ones in the Template tab, I just thought it would be reasonable to have a way to create grid layouts from the Custom tab (not by editing a template in the Templates tab).

@enricogior
Copy link
Contributor

@Defman21
when you edit a predefined template, it will generate a new custom layout, so the predefined template will remain unchanged and available as a template.

@enricogior enricogior added the Issue-Docs Documentation issue that needs to be improved label Nov 13, 2019
@Defman21
Copy link
Author

Yeah I understand that, it's just strange to have "create custom layout" in the Custom tab, but not "create custom grid layout".

@enricogior
Copy link
Contributor

If we put "Create custom grid layout" in the Custom tab, what would you expect the UI to be?
When "Create custom grid layout" is chosen, we would have to show the list of predefined templates that we currently show in the Template tab, right? So it would require two more steps compared to the current UI.
If you have a better UI in mind, let us know, suggestions to improve the user experience are always welcomed!

@Defman21
Copy link
Author

2 things that I would like to see:

  1. Show a tip that editing a template would actually create a custom grid template.
  2. Choosing "create custom grid layout" would create a basic area/rectangle/layout (gray area, I don't know the proper name of it) without splitters and you can then split it how you want. Not sure about how to deal with the initial splitter orientation (horizontal or vertical), but I have 2 suggestions there:
    a. Pick vertical orientation by default and change it near the left/right of the area
    b. Let the user rotate the splitter by holding Shift/Alt/Ctrl (again, it should be vertical by default imo)

@enricogior enricogior added Product-FancyZones Refers to the FancyZones PowerToy FancyZones-Editor Issue revolving the FancyZone Editor labels Nov 13, 2019
@enricogior
Copy link
Contributor

  1. Show a tip that editing a template would actually create a custom grid template.

Will do it. Thanks for the suggestion.

For number 2, that would require a considerable amount of work (not just for the coding but for the testing as well). Let's keep this issue open and see if it's something more people ask for it.

@crutkas crutkas mentioned this issue Dec 31, 2019
16 tasks
@enricogior enricogior removed the Product-FancyZones Refers to the FancyZones PowerToy label May 24, 2020
@crutkas crutkas added the Status-In progress This issue or work-item is under development label Dec 10, 2020
@crutkas
Copy link
Member

crutkas commented Dec 10, 2020

PR #8148 tweaks this and lets you
image

@enricogior enricogior changed the title No way to create a custom grid layout [FZ Editor] No way to create a custom grid layout Jan 3, 2021
@enricogior enricogior added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Jan 27, 2021
@enricogior
Copy link
Contributor

Fixed by #9325

@enricogior
Copy link
Contributor

Fixed in 0.31.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FancyZones-Editor Issue revolving the FancyZone Editor Issue-Docs Documentation issue that needs to be improved Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Development

No branches or pull requests

4 participants