Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error on FancyZones.cpp #1572

Closed
crutkas opened this issue Mar 13, 2020 · 4 comments
Closed

Build error on FancyZones.cpp #1572

crutkas opened this issue Mar 13, 2020 · 4 comments
Assignees
@yuyoyuppe
Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Quality Stability, Performance, Etc. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Milestone
Build 2020

Comments

@crutkas
Copy link
Member

crutkas commented Mar 13, 2020

Error C2228 left of '.showZonesOnAllMonitors' must have class/struct/union FancyZonesLib
C:\Users\crutkas\Source\Repos\PtMain\src\modules\fancyzones\lib\FancyZones.cpp 886

I'm on:
ID Author Date Message
8c17d82 Clint Rutkas clint@rutkas.com 3/13/2020 3:48:24 PM +00:00 moving the license.rtf file out of the root dir. compiled both msix and msi and both worked. (#1565)
@crutkas crutkas added Product-FancyZones Refers to the FancyZones PowerToy Area-Quality Stability, Performance, Etc. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Area-Build Issues pertaining to the build system, CI, infrastructure, meta labels Mar 13, 2020
@crutkas crutkas added this to the Build 2020 milestone Mar 13, 2020
@yuyoyuppe yuyoyuppe self-assigned this Mar 13, 2020
@enricogior
Copy link
Contributor

Opening the PR with the fix shortly.

@enricogior enricogior mentioned this issue Mar 13, 2020
Merged
1 task
@yuyoyuppe
Copy link
Contributor

yuyoyuppe commented Mar 13, 2020 •
edited
Loading

As for the cause of the break, these commits were building successfully in the isolation in their own PRs and didn't cause any merge conflicts, but when merged they still caused the build errors due to both touching the same class.

I wonder if we can set up the CI in a way that it cherry-picks PR commits against the actual master to prevent build breaks in the future or just requires for a feature branch to be rebased to the latest master.

@crutkas
Copy link
Member Author

crutkas commented Mar 13, 2020

The CI system would have blocked the PR from being merged due breaking the build.

@yuyoyuppe
Copy link
Contributor

@crutkas yes, that's exactly what I'd want for it to do automatically.

@enricogior enricogior added the Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. label Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuyoyuppe yuyoyuppe

Labels
Area-Build Issues pertaining to the build system, CI, infrastructure, meta Area-Quality Stability, Performance, Etc. Priority-0 Bugs that we consider release-blocking/recall-class (P0) Product-FancyZones Refers to the FancyZones PowerToy Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release.
Projects
None yet
Milestone
Build 2020
Development

No branches or pull requests
3 participants
@crutkas @yuyoyuppe @enricogior