Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fancy zones order does not follow cell-child-map settings #1425

Closed
totkeks opened this issue Mar 3, 2020 · 3 comments
Closed

Fancy zones order does not follow cell-child-map settings #1425

totkeks opened this issue Mar 3, 2020 · 3 comments

Comments

@totkeks
Copy link

totkeks commented Mar 3, 2020

Environment

Windows build number: 10.0.19041 Build 19041
PowerToys version: 0.15
PowerToy module for which you are reporting the bug (if applicable): Fancy Zones

Steps to reproduce

Change the configuration for a custom zone set's cell child map:

         "info": {
            "rows": 2,
            "columns": 3,
            "rows-percentage": [
               5000,
               5000
            ],
            "columns-percentage": [
               2500,
               5000,
               2500
            ],
            "cell-child-map": [
               [
                  0,
                  2,
                  3
               ],
               [
                  1,
                  2,
                  3
               ]
            ]
         }

Expected behavior

Moving order when using win+arrow key would be zone 0 (top left) to 1 (bottom left) to 2 (center) to 3 (right)

Actual behavior

Moving order when using win+arrow key is zone 0 to 2 to 3 to 1.

Related issues

I just assumed that cell-child-map works like that because it is new and didn't find documentation. But after looking at #1032 the numbers in the cell-child-map might just help placing the zones on the screen, but do not affect their order.

@crutkas
Copy link
Member

crutkas commented Mar 5, 2020

The v2 editor, there should be a 1:1 mapping. if a zone is number 2, it should be the 2nd zone in order. if this isn't a regression, i'm going to close it as covered by v2 editor

@crutkas
Copy link
Member

crutkas commented Mar 5, 2020

@totkeks please comment if you feel this is a regression, else i'm going to say v2 editor will solve this and we'll push that work there

@crutkas crutkas closed this as completed Mar 5, 2020
@crutkas
Copy link
Member

crutkas commented Mar 5, 2020

https://github.com/microsoft/PowerToys/blob/dev/crutkas/FzEditor2Spec/doc/specs/FancyZoneEditorV2.md is the current work in progress for the spec, fyi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants