Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Settings; Plugin manager] Improve visibility of warnings when plugin properties are collapsed #12865

Closed
htcfreek opened this issue Aug 24, 2021 · 3 comments
Closed

[Settings; Plugin manager] Improve visibility of warnings when plugin properties are collapsed #12865

htcfreek opened this issue Aug 24, 2021 · 3 comments
Assignees
@niels9001
Labels
Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager Severity-Regression This was working in a previous release

Comments

@htcfreek
Copy link
Collaborator

htcfreek commented Aug 24, 2021 •
edited
Loading

With the new settings ux (#12470) we have switched to a new settings ux and updated the styling.

Description of the new feature / enhancement

In some cases we show warnings (not accessible, incorrect activation command) in the plugin settings. On the old ux they were visibel without expanding the plugin settings. But on the new ux they are only visibel in expanded state.

Old ux
image

New ux
img01

Suggested improvement
We should add an warning icon with the tooltip text "Incorrect setting(s) detected" to the expander header. The icon should be visibel whenever a plugin has one or more incorrect settings.
img02

Scenario when this would be used?

Seeing incorrect configured plugins without expanding each plugin`s settings.

Supporting information

No response
@htcfreek htcfreek added Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application Run-Plugin Manager Issues with the PowerToys Run plugin manager labels Aug 24, 2021
@htcfreek
Copy link
Collaborator Author

@niels9001, can you please fix this before release. Thanks.

@htcfreek htcfreek added the Severity-Regression This was working in a previous release label Aug 24, 2021
@niels9001 niels9001 added Status-In progress This issue or work-item is under development Severity-Regression This was working in a previous release and removed Severity-Regression This was working in a previous release Needs-Triage For issues raised to be triaged and prioritized by internal Microsoft teams labels Aug 26, 2021
@niels9001 niels9001 mentioned this issue Aug 26, 2021
Merged
10 tasks
@htcfreek
Copy link
Collaborator Author

needs label fix

@niels9001 niels9001 added Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. and removed Status-In progress This issue or work-item is under development labels Aug 27, 2021
@dedavis6797
Copy link
Contributor

Resolved with the release of v0.45.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niels9001 niels9001

Labels
Idea-Enhancement New feature or request on an existing product Product-Settings The standalone PowerToys Settings application Resolution-Fix Committed Fix is checked in, but it might be 3-4 weeks until a release. Run-Plugin Manager Issues with the PowerToys Run plugin manager Severity-Regression This was working in a previous release
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niels9001 @dedavis6797 @htcfreek