From 45a544e1c8ed9f32b5d47e92584e7cfcf4e540ac Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 11:36:44 +0300 Subject: [PATCH 01/14] Enable trimming for clients using net5 or higher --- src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj | 1 + src/Microsoft.OpenApi/Microsoft.OpenApi.csproj | 1 + 2 files changed, 2 insertions(+) diff --git a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj index 94f633208..3b9ef012b 100644 --- a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj +++ b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj @@ -7,6 +7,7 @@ 2.0.0-preview4 OpenAPI.NET Readers for JSON and YAML documents true + true true NU5048 diff --git a/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj b/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj index 8753755ac..e071cff42 100644 --- a/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj +++ b/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj @@ -6,6 +6,7 @@ 2.0.0-preview4 .NET models with JSON and YAML writers for OpenAPI specification true + true true NU5048 From a5e9058d90b7845bea5cb2f14eb9c7d962c5a8c9 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 11:38:03 +0300 Subject: [PATCH 02/14] Add a reference to readers --- .../Microsoft.OpenApi.Trimming.Tests.csproj | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj index 08f51d715..68c02953d 100644 --- a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj +++ b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj @@ -4,6 +4,7 @@ net8.0 enable enable + true true false true @@ -14,7 +15,8 @@ - + + From 1093d9380c9b51b40065f5ccc74cefc96f3600cf Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 12:29:21 +0300 Subject: [PATCH 03/14] Use JsonSerializer context for source generation; compatible with AOT --- src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs b/src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs index 919f1d85c..a9f7c1394 100644 --- a/src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs +++ b/src/Microsoft.OpenApi/Reader/ParseNodes/MapNode.cs @@ -8,6 +8,7 @@ using System.Linq; using System.Text.Json; using System.Text.Json.Nodes; +using System.Text.Json.Serialization; using Microsoft.OpenApi.Any; using Microsoft.OpenApi.Exceptions; using Microsoft.OpenApi.Interfaces; @@ -114,7 +115,7 @@ IEnumerator IEnumerable.GetEnumerator() public override string GetRaw() { - var x = JsonSerializer.Serialize(_node); + var x = JsonSerializer.Serialize(_node, SourceGenerationContext.Default.JsonObject); return x; } @@ -176,4 +177,7 @@ public override JsonNode CreateAny() return _node; } } + + [JsonSerializable(typeof(JsonObject))] + internal partial class SourceGenerationContext : JsonSerializerContext { } } From 8ebab68b308e39c9cf4961b22364ef53f459ba7d Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 12:55:38 +0300 Subject: [PATCH 04/14] Annotate enumType param to preserve metadata during trimming --- src/Microsoft.OpenApi/Extensions/StringExtensions.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs index 1678f26dd..f272bfea9 100644 --- a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs +++ b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs @@ -45,7 +45,7 @@ internal static class StringExtensions result = default; return false; } - private static ReadOnlyDictionary GetEnumValues(Type enumType) where T : Enum + private static ReadOnlyDictionary GetEnumValues([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields)] Type enumType) where T : Enum { var result = new Dictionary(StringComparer.OrdinalIgnoreCase); foreach (var field in enumType.GetFields(BindingFlags.Public | BindingFlags.Static)) From ad1d5d75e6c3060a2d5c12a6395af9c1b778fd21 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 12:56:15 +0300 Subject: [PATCH 05/14] simplify code --- .../Validations/Rules/RuleHelpers.cs | 32 +++++++++---------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs b/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs index 4e05c44fd..61b9d3a0c 100644 --- a/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs +++ b/src/Microsoft.OpenApi/Validations/Rules/RuleHelpers.cs @@ -52,7 +52,7 @@ public static void ValidateDataTypeMismatch( } // convert value to JsonElement and access the ValueKind property to determine the type. - var jsonElement = JsonDocument.Parse(JsonSerializer.Serialize(value)).RootElement; + var valueKind = value.GetValueKind(); var type = schema.Type.ToIdentifier(); var format = schema.Format; @@ -60,7 +60,7 @@ public static void ValidateDataTypeMismatch( // Before checking the type, check first if the schema allows null. // If so and the data given is also null, this is allowed for any type. - if (nullable && jsonElement.ValueKind is JsonValueKind.Null) + if (nullable && valueKind is JsonValueKind.Null) { return; } @@ -70,7 +70,7 @@ public static void ValidateDataTypeMismatch( // It is not against the spec to have a string representing an object value. // To represent examples of media types that cannot naturally be represented in JSON or YAML, // a string value can contain the example with escaping where necessary - if (jsonElement.ValueKind is JsonValueKind.String) + if (valueKind is JsonValueKind.String) { return; } @@ -110,7 +110,7 @@ public static void ValidateDataTypeMismatch( // It is not against the spec to have a string representing an array value. // To represent examples of media types that cannot naturally be represented in JSON or YAML, // a string value can contain the example with escaping where necessary - if (jsonElement.ValueKind is JsonValueKind.String) + if (valueKind is JsonValueKind.String) { return; } @@ -138,7 +138,7 @@ public static void ValidateDataTypeMismatch( if (type is "integer" or "number" && format is "int32") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -150,7 +150,7 @@ public static void ValidateDataTypeMismatch( if (type is "integer" or "number" && format is "int64") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -162,7 +162,7 @@ public static void ValidateDataTypeMismatch( if (type is "integer") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -174,7 +174,7 @@ public static void ValidateDataTypeMismatch( if (type is "number" && format is "float") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -186,7 +186,7 @@ public static void ValidateDataTypeMismatch( if (type is "number" && format is "double") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -198,7 +198,7 @@ public static void ValidateDataTypeMismatch( if (type is "number") { - if (jsonElement.ValueKind is not JsonValueKind.Number) + if (valueKind is not JsonValueKind.Number) { context.CreateWarning( ruleName, @@ -210,7 +210,7 @@ public static void ValidateDataTypeMismatch( if (type is "string" && format is "byte") { - if (jsonElement.ValueKind is not JsonValueKind.String) + if (valueKind is not JsonValueKind.String) { context.CreateWarning( ruleName, @@ -222,7 +222,7 @@ public static void ValidateDataTypeMismatch( if (type is "string" && format is "date") { - if (jsonElement.ValueKind is not JsonValueKind.String) + if (valueKind is not JsonValueKind.String) { context.CreateWarning( ruleName, @@ -234,7 +234,7 @@ public static void ValidateDataTypeMismatch( if (type is "string" && format is "date-time") { - if (jsonElement.ValueKind is not JsonValueKind.String) + if (valueKind is not JsonValueKind.String) { context.CreateWarning( ruleName, @@ -246,7 +246,7 @@ public static void ValidateDataTypeMismatch( if (type is "string" && format is "password") { - if (jsonElement.ValueKind is not JsonValueKind.String) + if (valueKind is not JsonValueKind.String) { context.CreateWarning( ruleName, @@ -258,7 +258,7 @@ public static void ValidateDataTypeMismatch( if (type is "string") { - if (jsonElement.ValueKind is not JsonValueKind.String) + if (valueKind is not JsonValueKind.String) { context.CreateWarning( ruleName, @@ -270,7 +270,7 @@ public static void ValidateDataTypeMismatch( if (type is "boolean") { - if (jsonElement.ValueKind is not JsonValueKind.True && jsonElement.ValueKind is not JsonValueKind.False) + if (valueKind is not JsonValueKind.True && valueKind is not JsonValueKind.False) { context.CreateWarning( ruleName, From e8099450b80e4f9120c1c8ebea38daa077b184f5 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 14:12:54 +0300 Subject: [PATCH 06/14] Upgrade TFM and update API --- src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj | 2 +- test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj index 3b9ef012b..cd1b4d2ae 100644 --- a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj +++ b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj @@ -1,6 +1,6 @@ - netstandard2.0;net6.0; + netstandard2.0;net8.0; latest true diff --git a/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt b/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt index beae10400..317f1965c 100644 --- a/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt +++ b/test/Microsoft.OpenApi.Tests/PublicApi/PublicApi.approved.txt @@ -1,3 +1,4 @@ +[assembly: System.Reflection.AssemblyMetadata("IsTrimmable", "True")] [assembly: System.Reflection.AssemblyMetadata("RepositoryUrl", "https://github.com/Microsoft/OpenAPI.NET")] [assembly: System.Runtime.CompilerServices.InternalsVisibleTo(@"Microsoft.OpenApi.Readers.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100957cb48387b2a5f54f5ce39255f18f26d32a39990db27cf48737afc6bc62759ba996b8a2bfb675d4e39f3d06ecb55a178b1b4031dcb2a767e29977d88cce864a0d16bfc1b3bebb0edf9fe285f10fffc0a85f93d664fa05af07faa3aad2e545182dbf787e3fd32b56aca95df1a3c4e75dec164a3f1a4c653d971b01ffc39eb3c4")] [assembly: System.Runtime.CompilerServices.InternalsVisibleTo(@"Microsoft.OpenApi.Tests, PublicKey=0024000004800000940000000602000000240000525341310004000001000100957cb48387b2a5f54f5ce39255f18f26d32a39990db27cf48737afc6bc62759ba996b8a2bfb675d4e39f3d06ecb55a178b1b4031dcb2a767e29977d88cce864a0d16bfc1b3bebb0edf9fe285f10fffc0a85f93d664fa05af07faa3aad2e545182dbf787e3fd32b56aca95df1a3c4e75dec164a3f1a4c653d971b01ffc39eb3c4")] From 74f2c4388807b2e691b1d50c79ed49ab02d32863 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Wed, 15 Jan 2025 14:31:20 +0300 Subject: [PATCH 07/14] Add workflow to validate project for trimming --- .github/workflows/ci-cd.yml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index 13a34f171..ff11d7dd5 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -36,3 +36,18 @@ jobs: shell: pwsh run: | dotnet test Microsoft.OpenApi.sln -c Release -v n + + validate-trimming: + name: Validate Project for Trimming + runs-on: windows-latest + steps: + - uses: actions/checkout@v4.1.7 + + - name: Setup .NET + uses: actions/setup-dotnet@v4 + with: + dotnet-version: 8.x + + - name: Validate Trimming warnings + run: dotnet publish -c Release -r win-x64 /p:TreatWarningsAsErrors=true /warnaserror -f net8.0 + working-directory: ./test/Microsoft.OpenApi.Trimming.Tests From 5d56fac2f9958b6cabeb1bece3e530b0145a8a20 Mon Sep 17 00:00:00 2001 From: Vincent Biret Date: Wed, 15 Jan 2025 07:26:17 -0500 Subject: [PATCH 08/14] Update .github/workflows/ci-cd.yml --- .github/workflows/ci-cd.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci-cd.yml b/.github/workflows/ci-cd.yml index ff11d7dd5..2ddce58b7 100644 --- a/.github/workflows/ci-cd.yml +++ b/.github/workflows/ci-cd.yml @@ -41,7 +41,7 @@ jobs: name: Validate Project for Trimming runs-on: windows-latest steps: - - uses: actions/checkout@v4.1.7 + - uses: actions/checkout@v4 - name: Setup .NET uses: actions/setup-dotnet@v4 From c4a446c70eda6cadcf1f21ec5f7342ec90b94fe0 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 10:59:58 +0300 Subject: [PATCH 09/14] Ensure trimmer preserves metadata for DisplayAttribute properties --- src/Microsoft.OpenApi/Extensions/StringExtensions.cs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs index f272bfea9..7f5b0f89d 100644 --- a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs +++ b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs @@ -45,7 +45,8 @@ internal static class StringExtensions result = default; return false; } - private static ReadOnlyDictionary GetEnumValues([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields)] Type enumType) where T : Enum + private static ReadOnlyDictionary GetEnumValues([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields + | DynamicallyAccessedMemberTypes.PublicProperties)] Type enumType) where T : Enum { var result = new Dictionary(StringComparer.OrdinalIgnoreCase); foreach (var field in enumType.GetFields(BindingFlags.Public | BindingFlags.Static)) From 0bf3dbbf13783257a89372548dfc08219729931e Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 15:27:56 +0300 Subject: [PATCH 10/14] Ignore warning --- .../Microsoft.OpenApi.Trimming.Tests.csproj | 2 ++ 1 file changed, 2 insertions(+) diff --git a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj index 68c02953d..1a0a95a22 100644 --- a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj +++ b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj @@ -8,6 +8,8 @@ true false true + IL3000 + NU1903 false From 268a39819d7bc247a93cb1834868eacea6c56442 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 16:16:15 +0300 Subject: [PATCH 11/14] Fix trimming errors --- src/Microsoft.OpenApi/Extensions/StringExtensions.cs | 5 ++--- .../Microsoft.OpenApi.Trimming.Tests.csproj | 4 +--- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs index 7f5b0f89d..b644050ab 100644 --- a/src/Microsoft.OpenApi/Extensions/StringExtensions.cs +++ b/src/Microsoft.OpenApi/Extensions/StringExtensions.cs @@ -34,7 +34,7 @@ internal static class StringExtensions { var type = typeof(T); - var displayMap = EnumDisplayCache.GetOrAdd(type, GetEnumValues); + var displayMap = EnumDisplayCache.GetOrAdd(type, _=> GetEnumValues(type)); if (displayMap.TryGetValue(displayName, out var cachedValue)) { @@ -45,8 +45,7 @@ internal static class StringExtensions result = default; return false; } - private static ReadOnlyDictionary GetEnumValues([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields - | DynamicallyAccessedMemberTypes.PublicProperties)] Type enumType) where T : Enum + private static ReadOnlyDictionary GetEnumValues([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicFields)] Type enumType) where T : Enum { var result = new Dictionary(StringComparer.OrdinalIgnoreCase); foreach (var field in enumType.GetFields(BindingFlags.Public | BindingFlags.Static)) diff --git a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj index 1a0a95a22..fad2dc289 100644 --- a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj +++ b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj @@ -8,9 +8,7 @@ true false true - IL3000 - - NU1903 + NU1903; IL3000 false From 3a35cb9328b7dec61b900372bc7f86331664df2d Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 18:36:19 +0300 Subject: [PATCH 12/14] Add MSBuild property to identify project-specific trimmer warnings --- src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj | 1 + src/Microsoft.OpenApi/Microsoft.OpenApi.csproj | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj index cd1b4d2ae..0bcee86ba 100644 --- a/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj +++ b/src/Microsoft.OpenApi.Readers/Microsoft.OpenApi.Readers.csproj @@ -8,6 +8,7 @@ OpenAPI.NET Readers for JSON and YAML documents true true + true true NU5048 diff --git a/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj b/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj index e071cff42..4156863b5 100644 --- a/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj +++ b/src/Microsoft.OpenApi/Microsoft.OpenApi.csproj @@ -6,7 +6,8 @@ 2.0.0-preview4 .NET models with JSON and YAML writers for OpenAPI specification true - true + true + true true NU5048 From 7e512ab29567c65f7a42b6e21cd3b4ac194818d9 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 18:36:57 +0300 Subject: [PATCH 13/14] Resolve trimmer warnings --- src/Microsoft.OpenApi/Models/OpenApiSchema.cs | 4 ++++ .../Microsoft.OpenApi.Trimming.Tests.csproj | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/Microsoft.OpenApi/Models/OpenApiSchema.cs b/src/Microsoft.OpenApi/Models/OpenApiSchema.cs index 0ebe9eab9..d2ffa88ed 100644 --- a/src/Microsoft.OpenApi/Models/OpenApiSchema.cs +++ b/src/Microsoft.OpenApi/Models/OpenApiSchema.cs @@ -846,7 +846,11 @@ where Type.Value.HasFlag(flag) writer.WriteOptionalCollection(OpenApiConstants.Type, list, (w, s) => w.WriteValue(s)); } +#if NET5_0_OR_GREATER + private static readonly Array jsonSchemaTypeValues = System.Enum.GetValues(); +#else private static readonly Array jsonSchemaTypeValues = System.Enum.GetValues(typeof(JsonSchemaType)); +#endif private void DowncastTypeArrayToV2OrV3(JsonSchemaType schemaType, IOpenApiWriter writer, OpenApiSpecVersion version) { diff --git a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj index fad2dc289..68c02953d 100644 --- a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj +++ b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj @@ -8,7 +8,7 @@ true false true - NU1903; IL3000 + NU1903 false From 7a821741c5dc7c78a2a229c66a6488e0152fd041 Mon Sep 17 00:00:00 2001 From: Maggiekimani1 Date: Thu, 16 Jan 2025 18:57:32 +0300 Subject: [PATCH 14/14] Revert change --- .../Microsoft.OpenApi.Trimming.Tests.csproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj index 68c02953d..fad2dc289 100644 --- a/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj +++ b/test/Microsoft.OpenApi.Trimming.Tests/Microsoft.OpenApi.Trimming.Tests.csproj @@ -8,7 +8,7 @@ true false true - NU1903 + NU1903; IL3000 false