Skip to content

Commit 283dab0

Browse files
committed
Sync RunVSTestTask task params
1 parent ef8f11a commit 283dab0

File tree

2 files changed

+3
-25
lines changed

2 files changed

+3
-25
lines changed

src/RunTests/RunVSTestTask.cs

-24
Original file line numberDiff line numberDiff line change
@@ -15,11 +15,6 @@ public class RunVSTestTask : ToolTask
1515
private static readonly HashSet<string> NormalTestLogging = new (new[] { "n", "normal", "d", "detailed", "diag", "diagnostic" }, StringComparer.OrdinalIgnoreCase);
1616
private static readonly HashSet<string> QuietTestLogging = new (new[] { "q", "quiet" }, StringComparer.OrdinalIgnoreCase);
1717

18-
/// <summary>
19-
/// Gets or Sets Full path to the test file.
20-
/// </summary>
21-
public string IsTestProject { get; set; }
22-
2318
/// <summary>
2419
/// Gets or Sets Full path to the test file.
2520
/// </summary>
@@ -65,19 +60,6 @@ public class RunVSTestTask : ToolTask
6560
/// </summary>
6661
public string VSTestDiag { get; set; }
6762

68-
/// <summary>
69-
/// Gets or Sets Command line options for VSTest.
70-
/// </summary>
71-
public string[] VSTestCLIRunSettings { get; set; }
72-
73-
// Initialized to empty string to allow declaring as non-nullable, the property is marked as
74-
// required so we can ensure that the property is set to non-null before the task is executed.
75-
76-
/// <summary>
77-
/// Gets or Sets Path to VSTest console executable.
78-
/// </summary>
79-
public string VSTestConsolePath { get; set; } = string.Empty;
80-
8163
/// <summary>
8264
/// Gets or Sets Directory where VSTest results are saved.
8365
/// </summary>
@@ -148,12 +130,6 @@ public class RunVSTestTask : ToolTask
148130
/// </summary>
149131
public string VSTestSessionCorrelationId { get; set; }
150132

151-
/// <summary>
152-
/// Gets or Sets Runner version of VSTest.
153-
/// </summary>
154-
[Required]
155-
public string VSTestRunnerVersion { get; set; }
156-
157133
protected override string ToolName => "vstest.console.exe";
158134

159135
protected override MessageImportance StandardOutputLoggingImportance => MessageImportance.High;

src/RunTests/build/Microsoft.Build.RunVSTest.targets

+3-1
Original file line numberDiff line numberDiff line change
@@ -8,14 +8,15 @@
88
<UsingTask TaskName="Microsoft.Build.RunVSTestTask" AssemblyFile="$(MSBuildThisFileDirectory)netstandard2.0\Microsoft.Build.RunVSTest.dll" Condition="'$(MSBuildRuntime)' != 'Core'"/>
99
<Target Name="RunVSTest" AfterTargets="Test" Condition="'$(MSBuildRuntime)' != 'Core'">
1010
<RunVSTestTask
11-
VSTestRunnerVersion="$(VSTestRunnerVersion)"
1211
TestFileFullPath="$(TargetPath)"
1312
VSTestSetting="$(VSTestSetting)"
1413
VSTestTestAdapterPath="$(VSTestTestAdapterPath)"
1514
VSTestFramework="$(VSTestFramework)"
1615
VSTestPlatform="$(VSTestPlatform)"
1716
VSTestTestCaseFilter="$(VSTestTestCaseFilter)"
1817
VSTestLogger="$(VSTestLogger)"
18+
VSTestListTests="$(VSTestListTests)"
19+
VSTestDiag="$(VSTestDiag)"
1920
VSTestResultsDirectory="$(VSTestResultsDirectory)"
2021
VSTestVerbosity="$(VSTestVerbosity)"
2122
VSTestCollect="$(VSTestCollect)"
@@ -25,6 +26,7 @@
2526
VSTestBlameCrashCollectAlways="$(VSTestBlameCrashCollectAlways)"
2627
VSTestBlameHang="$(VSTestBlameHang)"
2728
VSTestBlameHangDumpType="$(VSTestBlameHangDumpType)"
29+
VSTestBlameHangTimeout="$(VSTestBlameHangTimeout)"
2830
VSTestTraceDataCollectorDirectoryPath="$(VSTestTraceDataCollectorDirectoryPath)"
2931
VSTestNoLogo="$(VSTestNoLogo)"
3032
VSTestArtifactsProcessingMode="$(VSTestArtifactsProcessingMode)"

0 commit comments

Comments
 (0)