Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[c++] Adding checks for nullptr in the code #5085

Closed
shiyu1994 opened this issue Mar 21, 2022 · 2 comments
Closed

[c++] Adding checks for nullptr in the code #5085

shiyu1994 opened this issue Mar 21, 2022 · 2 comments

Comments

@shiyu1994
Copy link
Collaborator

Summary

In our code base, we seldom check whether a pointer passed from argument is nullptr, before dereferencing it. For example,

*boosting = "gbdt";

This is discussed in #4827 (comment)

Motivation

Adding checks like this will make the code more robust.

@shiyu1994
Copy link
Collaborator Author

Closed in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open this issue (or post a comment if you are not a topic starter) if you are actively working on implementing this feature.

@github-actions

This comment was marked as off-topic.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
@microsoft microsoft unlocked this conversation Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant