Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Improve portability of OpenMP checks in R-package configure on macOS #4537

Closed
StrikerRUS opened this issue Aug 19, 2021 · 2 comments

Comments

@StrikerRUS
Copy link
Collaborator

Originally discussed in #4507 (comment).

Right now, configure.ac checks compilation on macOS with -Xclang -fopenmp OpenMP flags. In case of failure, it tries to compile one more time with default -fopenmp flag. I think we can improve that check by trying to compile with some other OpenMP flags with the aim to support more compilers.

if test `uname -s` = "Darwin"

Possible flags to check: https://github.com/autoconf-archive/autoconf-archive/blob/6c25681d78d963708362ea0d4d63ee9b508782b6/m4/ax_openmp.m4#L82.

@StrikerRUS
Copy link
Collaborator Author

Closing in favor of being in #2302. We decided to keep all feature requests in one place.

Welcome to contribute this feature! Please re-open (or post a comment if you are not a topic starter) this issue if you are actively working on implementing this feature.

@jameslamb jameslamb changed the title Improve portability of OpenMP checks in R-package configure on macOS [R-package] Improve portability of OpenMP checks in R-package configure on macOS Dec 27, 2021
@github-actions

This comment was marked as off-topic.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 16, 2023
@microsoft microsoft unlocked this conversation Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants