Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R-package] Export callback functions #2479

Open
3 tasks
jameslamb opened this issue Sep 30, 2019 · 6 comments
Open
3 tasks

[R-package] Export callback functions #2479

jameslamb opened this issue Sep 30, 2019 · 6 comments

Comments

@jameslamb
Copy link
Collaborator

See this comment and this comment thread from #2443 . Currently the functions in callback.R are not exported in the R package. This means that the use of callbacks keyword argument in lgb.train() is unclear.

To close this issue, submit a PR with the following features

  • Roxygen documentation on relevant functions in R-package/callbacks.R, including @export tag. Consider also using @family tag to auto-generate see-also links.
  • regenerated .Rd documentation (see this comment for how to do this). This should also regenerate R-package/NAMESPACE.
  • updated documentation in any other functions that expose callbacks, linking to the relevant documentation
@jameslamb
Copy link
Collaborator Author

Closing this in favor of being in #2302 . We keep all feature requests in #2302 . If you'd like to pick this issue up and submit a PR, please do and it can be re-opened.

@StrikerRUS
Copy link
Collaborator

Open because of active PR #5018 for this issue.

@StrikerRUS StrikerRUS reopened this Feb 19, 2022
@jameslamb
Copy link
Collaborator Author

PR #5018 has been closed. Since there's no active work going on for this feature, I'm going to close this issue.

Anyone interested in this feature is welcome to contribute it! If you'd like to contribute this, comment here and the issue can be re-opened. Maintainers will be happy to help you.

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed.
To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues
including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2023
@microsoft microsoft unlocked this conversation Nov 7, 2023
@jameslamb jameslamb reopened this Nov 7, 2023
@jameslamb jameslamb self-assigned this Jan 3, 2024
@StrikerRUS
Copy link
Collaborator

@jameslamb I see you

self-assigned this on Jan 3

Are you still working on this feature request?

@jameslamb
Copy link
Collaborator Author

Yes, thanks for the reminder, I'd like to get to this within the next release cycle. Not having it is blocking #6172. Let's leave it open please.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants