Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement compaction of the kvindex #63

Closed
jeffa5 opened this issue Sep 29, 2022 · 4 comments · Fixed by #203
Closed

Implement compaction of the kvindex #63

jeffa5 opened this issue Sep 29, 2022 · 4 comments · Fixed by #203
Labels
enhancement New feature or request M Less than 1 week p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work).

Comments

@jeffa5
Copy link
Collaborator

jeffa5 commented Sep 29, 2022

The current implementation of the compact endpoint is just focused on cleaning up revoked leases, not on the kvindex at the moment.
@jeffa5 jeffa5 added enhancement New feature or request M Less than 1 week p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work). labels Oct 4, 2022
@jeffa5
Copy link
Collaborator Author

jeffa5 commented Oct 4, 2022

Endpoint is currently implemented and used for lease compaction (actually removing keys).

@jeffa5
Copy link
Collaborator Author

jeffa5 commented Nov 9, 2022

Waiting for a release with microsoft/CCF#4352 in to be able to implement this

@jeffa5 jeffa5 added the blocked Blocked on another issue label Nov 9, 2022
@jeffa5 jeffa5 mentioned this issue Nov 9, 2022
Open
21 tasks
@jumaffre
Copy link
Contributor

With CCF 4.0.0-dev0, this should no longer be blocked?

@jeffa5 jeffa5 mentioned this issue Dec 16, 2022
Merged
@jeffa5 jeffa5 removed the blocked Blocked on another issue label Dec 16, 2022
@heidihoward
Copy link
Member

Can compaction now be ticked off on #35?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request M Less than 1 week p2 Nice-to-have. Work we want to pick up at one point but not urgent or critical (ie, hardening work).
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement KV compaction microsoft/LSKV
3 participants
@heidihoward @jeffa5 @jumaffre