-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create accelerator for apple silicon GPU Acceleration #3907
Conversation
@microsoft-github-policy-service agree |
Hey DeepSpeed team @tjruwase @ShijieZZZZ @jeffra, could you take a look at my code here? I appreciate the feedback. |
@NripeshN, thanks for contributing this exciting PR. We are reviewing asap. Out of curiosity, are you already running DeepSpeed on the mps accelerator? |
This is an excellent first step towards supporting apple silicon, thank you so much @NripeshN for initiating this. I've been doing some tests on my own M1 macbook air. I see a handful of other areas that will need fixes outside the abstract accelerator in order to run DeepSpeed training on M1. However, I think we'll need to have some follow-up PRs to address those. One area I see is even with using a torch.distributed backend of DeepSpeed/deepspeed/runtime/engine.py Line 1033 in aa54dba
After I added a few of these guards I was successfully able to get our simple/small model to run with fp32 weights https://github.com/microsoft/DeepSpeed/blob/master/tests/small_model_debugging/test_model.py I did get a seg fault when trying to use fp16 training, but I am not sure how stable that is on M1 even w/o DeepSpeed currently. |
Hi, Thank you soo much!! |
May fix #3364 and fix #1580