Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Improve performance of GUID lookup for types #686

Closed
Scottj1s opened this issue Jan 23, 2021 · 1 comment · Fixed by #849
Closed

Performance: Improve performance of GUID lookup for types #686

Scottj1s opened this issue Jan 23, 2021 · 1 comment · Fixed by #849
Assignees
@j0shuams
Labels
enhancement New feature or request fixed Issue has been fixed in an upcoming or existing release performance Related to performance work
Milestone
Release 1.3.3

Comments

@Scottj1s
Copy link
Member

guid calculation for collections is expensive. a source generator could be used to analyze all generic constructions, pre-generate their guids, and hard code them in a lookup table.
@Scottj1s Scottj1s added bug Something isn't working enhancement New feature or request performance Related to performance work labels Jan 23, 2021
@AdamBraden AdamBraden added this to the Release 1.1.2 milestone Jan 28, 2021
@angelazhangmsft angelazhangmsft removed the bug Something isn't working label Mar 30, 2021
@Scottj1s
Copy link
Member Author

Scottj1s commented Apr 30, 2021 •
edited
Loading

Alternately, based on a prototype by Jeremy, would be to rewrite the IL after projection assembly generation.
https://github.com/jkoritzinsky/WinRTPrecompile/tree/main/WinRTGuidPatcher

@manodasanW manodasanW changed the title Performance: use source generator to create guid lookaside list Performance: Improve performance of GUID lookup for types May 6, 2021
@j0shuams j0shuams mentioned this issue May 24, 2021
Merged
@angelazhangmsft angelazhangmsft added the fixed Issue has been fixed in an upcoming or existing release label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@j0shuams j0shuams

Labels
enhancement New feature or request fixed Issue has been fixed in an upcoming or existing release performance Related to performance work
Projects
None yet
Milestone
Release 1.3.3
Development

Successfully merging a pull request may close this issue.

[Perf] Add IID Lookup Optimization microsoft/CsWinRT
5 participants
@manodasanW @AdamBraden @Scottj1s @angelazhangmsft @j0shuams