Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider emitting GeneratedCodeAttribute on all generated types #594

Closed
AArnott opened this issue Jun 24, 2022 · 1 comment · Fixed by #621
Closed

Consider emitting GeneratedCodeAttribute on all generated types #594

AArnott opened this issue Jun 24, 2022 · 1 comment · Fixed by #621
Labels
enhancement New feature or request

Comments

@AArnott
Copy link
Member

AArnott commented Jun 24, 2022

See the docs for the attribute. The LibraryImportAttribute source generator emits code that uses this. It seems like a possibly good idea.
@AArnott AArnott added the enhancement New feature or request label Jun 24, 2022
@elachlan
Copy link
Contributor

The GeneratedCodeAttribute doesn't have AllowMultiple, so it can only be applied to a single file of a partial class/struct. This seems super weird since I would imagine you want to tag each code file with the attribute.
https://docs.microsoft.com/en-us/dotnet/api/system.codedom.compiler.generatedcodeattribute?view=net-6.0

@elachlan elachlan mentioned this issue Jul 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add GeneratedCodeAttribute to Generated code elachlan/CsWin32
2 participants
@AArnott @elachlan