Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/node/quotes/self fails when some of the collateral becomes expired #2651

Closed
achamayou opened this issue Jun 10, 2021 · 0 comments
Closed

/node/quotes/self fails when some of the collateral becomes expired #2651

achamayou opened this issue Jun 10, 2021 · 0 comments
Assignees
Labels
1.x-backport Highlights PRs targeting the 1.x branch bug

Comments

@achamayou
Copy link
Member

/node/quotes/self validates the quote to extract claims such as mrenclave. When some of the collateral expires (eg. the CRL), even though it had been valid at join time, users are unable to extract claims and the endpoint returns an error.

The right fix would be to validate the collateral against the timestamps of the quote in this context, rather than the current time, but oe_verify_evidence() doesn't provide that functionality. For now we can parse those claims at join time, store them in the ledger and retrieve them from there.

@achamayou achamayou added bug 1.x-backport Highlights PRs targeting the 1.x branch labels Jun 10, 2021
@achamayou achamayou changed the title /node/quotes/self fails when the some of the collateral becomes expired /node/quotes/self fails when some of the collateral becomes expired Jun 23, 2021
@achamayou achamayou self-assigned this Jun 23, 2021
@achamayou achamayou mentioned this issue Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.x-backport Highlights PRs targeting the 1.x branch bug
Projects
None yet
Development

No branches or pull requests

1 participant