From 2a9129e6213834c4c606cea4a2789edd7d6d70db Mon Sep 17 00:00:00 2001 From: Corina <14900841+corinagum@users.noreply.github.com> Date: Wed, 23 Oct 2019 15:17:02 -0700 Subject: [PATCH 1/3] add audioConfig prop to Speech SDK Ponyfill --- CHANGELOG.md | 1 + .../src/createCognitiveServicesSpeechServicesPonyfillFactory.js | 2 ++ 2 files changed, 3 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 023db37729..493c0a3471 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -104,6 +104,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#2461](https://github.com/Microsoft/BotFramework-WebChat/issues/2461), added `isomorphic-react` and `isomorphic-react-dom` packages, by [@compulim](https://github.com/compulim) and [@corinagum](https://github.com/corinagum), in PR [#2478](https://github.com/microsoft/BotFramework-WebChat/pull/2478) - Added missing Norwegian (nb-NO) translations, by [@taarskog](https://github.com/taarskog) - Added missing Italian (it-IT) translations, by [@AntoT84](https://github.com/AntoT84) +- Resolve [#2481](https://github.com/microsoft/BotFramework-WebChat/issues/2481). Support alternative audio input source by adding `audioConfig` prop to `createCognitiveServicesSpeechServicesPonyfillFactory`, by [@corinagum](https://github.com/corinagum), in PR [#xxx](https://github.com/microsoft/BotFramework-WebChat/pull/xxx) ### Samples diff --git a/packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js b/packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js index 29d54de921..3820d3343e 100644 --- a/packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js +++ b/packages/bundle/src/createCognitiveServicesSpeechServicesPonyfillFactory.js @@ -1,6 +1,7 @@ import createPonyfill from 'web-speech-cognitive-services/lib/SpeechServices'; export default function createCognitiveServicesSpeechServicesPonyfillFactory({ + audioConfig, authorizationToken, enableTelemetry, region, @@ -16,6 +17,7 @@ export default function createCognitiveServicesSpeechServicesPonyfillFactory({ return ({ referenceGrammarID }) => { const ponyfill = createPonyfill({ + audioConfig, authorizationToken, enableTelemetry, referenceGrammars: [`luis/${referenceGrammarID}-PRODUCTION`], From b5ffaae09d6f6a7ce0c5743e4a2fa8d2b71f3234 Mon Sep 17 00:00:00 2001 From: Corina <14900841+corinagum@users.noreply.github.com> Date: Wed, 23 Oct 2019 15:20:19 -0700 Subject: [PATCH 2/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 493c0a3471..1365352062 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -104,7 +104,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#2461](https://github.com/Microsoft/BotFramework-WebChat/issues/2461), added `isomorphic-react` and `isomorphic-react-dom` packages, by [@compulim](https://github.com/compulim) and [@corinagum](https://github.com/corinagum), in PR [#2478](https://github.com/microsoft/BotFramework-WebChat/pull/2478) - Added missing Norwegian (nb-NO) translations, by [@taarskog](https://github.com/taarskog) - Added missing Italian (it-IT) translations, by [@AntoT84](https://github.com/AntoT84) -- Resolve [#2481](https://github.com/microsoft/BotFramework-WebChat/issues/2481). Support alternative audio input source by adding `audioConfig` prop to `createCognitiveServicesSpeechServicesPonyfillFactory`, by [@corinagum](https://github.com/corinagum), in PR [#xxx](https://github.com/microsoft/BotFramework-WebChat/pull/xxx) +- Resolve [#2481](https://github.com/microsoft/BotFramework-WebChat/issues/2481). Support alternative audio input source by adding `audioConfig` prop to `createCognitiveServicesSpeechServicesPonyfillFactory`, by [@corinagum](https://github.com/corinagum), in PR [#2491](https://github.com/microsoft/BotFramework-WebChat/pull/2491) ### Samples From 9aa2e907b1b6911c7713a6aefb30924b7bce95e5 Mon Sep 17 00:00:00 2001 From: William Wong Date: Wed, 23 Oct 2019 16:42:31 -0700 Subject: [PATCH 3/3] Update CHANGELOG.md --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3a4fc59fbd..4caa160b84 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -105,7 +105,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - Fix [#2461](https://github.com/Microsoft/BotFramework-WebChat/issues/2461), added `isomorphic-react` and `isomorphic-react-dom` packages, by [@compulim](https://github.com/compulim) and [@corinagum](https://github.com/corinagum), in PR [#2478](https://github.com/microsoft/BotFramework-WebChat/pull/2478) and PR [#2486](https://github.com/microsoft/BotFramework-WebChat/pull/2486) - Added missing Norwegian (nb-NO) translations, by [@taarskog](https://github.com/taarskog) - Added missing Italian (it-IT) translations, by [@AntoT84](https://github.com/AntoT84) -- Resolve [#2481](https://github.com/microsoft/BotFramework-WebChat/issues/2481). Support alternative audio input source by adding `audioConfig` prop to `createCognitiveServicesSpeechServicesPonyfillFactory`, by [@corinagum](https://github.com/corinagum), in PR [#2491](https://github.com/microsoft/BotFramework-WebChat/pull/2491) +- Fixed [#2481](https://github.com/microsoft/BotFramework-WebChat/issues/2481). Support alternative audio input source by adding `audioConfig` prop to `createCognitiveServicesSpeechServicesPonyfillFactory`, by [@corinagum](https://github.com/corinagum), in PR [#2491](https://github.com/microsoft/BotFramework-WebChat/pull/2491) ### Samples