diff --git a/CHANGELOG.md b/CHANGELOG.md index c78a9e213e..b9a9367c6d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -39,6 +39,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0. - `connectCarouselFilmStrip`: Fixed `botAvatarInitials` and `userAvatarInitials` functionality from [recent name change](https://github.com/Microsoft/BotFramework-WebChat/pull/1486), - `BasicTranscript`: Fixed user activity should not be recreated after receive ACK from Direct Line, - by [@corinagum](https://github.com/corinagum) in PR [#1528](https://github.com/Microsoft/BotFramework-WebChat/pull/1528) +- Fix [#1560](https://github.com/Microsoft/BotFramework-WebChat/issues/1560). Fixed carousel layout did not show date and alignment issues, by [@compulim](https://github.com/compulim) in PR [#1561](https://github.com/Microsoft/BotFramework-WebChat/pull/1561) ### Removed - `botAvatarImage` and `userAvatarImage` props, as they are moved inside `styleOptions`, in PR [#1486](https://github.com/Microsoft/BotFramework-WebChat/pull/1486) diff --git a/__tests__/__image_snapshots__/chrome-docker/basic-js-setup-1-snap.png b/__tests__/__image_snapshots__/chrome-docker/basic-js-setup-1-snap.png index 5c56a61427..6752ac2cfb 100644 Binary files a/__tests__/__image_snapshots__/chrome-docker/basic-js-setup-1-snap.png and b/__tests__/__image_snapshots__/chrome-docker/basic-js-setup-1-snap.png differ diff --git a/__tests__/basic.js b/__tests__/basic.js index fc788737dd..fb0467c3c0 100644 --- a/__tests__/basic.js +++ b/__tests__/basic.js @@ -19,5 +19,8 @@ test('setup', async () => { const base64PNG = await driver.takeScreenshot(); - expect(base64PNG).toMatchImageSnapshot(); + expect(base64PNG).toMatchImageSnapshot({ + failureThreshold: 10, + failureThresholdType: 'pixel' + }); }, 60000); diff --git a/packages/component/src/Styles/StyleSet/CarouselFilmStrip.js b/packages/component/src/Styles/StyleSet/CarouselFilmStrip.js index 809c05c61c..f3faaa44db 100644 --- a/packages/component/src/Styles/StyleSet/CarouselFilmStrip.js +++ b/packages/component/src/Styles/StyleSet/CarouselFilmStrip.js @@ -6,23 +6,38 @@ export default function ({ return { // Browser quirks: Firefox has no way to hide scrollbar and while keeping it in function // https://developer.mozilla.org/en-US/docs/Web/CSS/overflow - marginBottom: -17, - paddingLeft: paddingRegular, - paddingRight: paddingRegular, + '@supports (-moz-appearance: none)': { + marginBottom: -17 + }, '& > .avatar': { marginRight: paddingRegular }, - '& > .content > ul': { - '&:not(:first-child)': { - marginTop: paddingRegular + '& > .content': { + '& > .message': { + marginLeft: paddingRegular + }, + + '& > ul': { + '&:not(:first-child)': { + marginLeft: paddingRegular, + marginRight: paddingRegular, + marginTop: paddingRegular + }, + + '& > li': { + maxWidth: bubbleMaxWidth, + minWidth: bubbleMinWidth, + + '&:not(:last-child)': { + marginRight: paddingRegular + } + } }, - '& > li': { - marginRight: paddingRegular, - maxWidth: bubbleMaxWidth, - minWidth: bubbleMinWidth + '& > .row': { + marginLeft: paddingRegular } } };