Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

p-defer is impacting ES5 build #3977

Closed
compulim opened this issue Jul 7, 2021 · 0 comments · Fixed by #3978
Closed

p-defer is impacting ES5 build #3977

compulim opened this issue Jul 7, 2021 · 0 comments · Fixed by #3978
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.
Milestone
R14

Comments

@compulim
Copy link
Contributor

compulim commented Jul 7, 2021

Screenshots

image

Version

main (related to #3974)

Describe the bug

In PR #3974, we imported p-defer instead of p-defer-es5, which is transpiled to ES5 on install-time.

p-defer exported via their main field is not ES5 compatible. And our build pipeline is set not to transpile node_modules/*.

Steps to reproduce

  1. Using IE11 or IE Mode, navigate to a page with Web Chat

Expected behavior

It should load properly.

Additional context

[Bug]
@compulim compulim added the bug Indicates an unexpected problem or an unintended behavior. label Jul 7, 2021
@compulim compulim added this to the R14 milestone Jul 7, 2021
@compulim compulim self-assigned this Jul 7, 2021
@compulim compulim mentioned this issue Jul 7, 2021
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
R14
Development

Successfully merging a pull request may close this issue.

Use p-defer-es5 instead compulim/BotFramework-WebChat
1 participant
@compulim