Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please update to latest version of AdaptiveCards (schema 1.4, SDK 2.9) #3828

Closed
eyadon opened this issue Apr 1, 2021 · 5 comments
Closed
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label

Comments

@eyadon
Copy link

eyadon commented Apr 1, 2021

I started out writing this as a bug, but while gathering documentation connected the dots that the issue I am seeing (below) is due to webchat being on an older version of the AdaptiveCards library.

Screenshots

No buttons pressed
image

Button without validation pressed
image

Button with validation pressed
image

Version

NPM package 4.12.1

Webchat updated to AdaptiveCards schema version 1.3, but doesn't seem to support the associatedInputs property on Action.Submit, which means in order to cancel out of the form, you have to fill it out first...

[feature-request]

@eyadon eyadon added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label labels Apr 1, 2021
@compulim
Copy link
Contributor

compulim commented Apr 2, 2021

FYI, we often bump Adaptive Cards to their latest version immediately after every major release of Web Chat.

Our bump history and strategy:

  • The last bump was done in December 2020 (PR Bump adaptivecards@2.5.0 #3630, dated 2020/12/7, after we released Web Chat 4.11)
  • Between 2020/10/30 and 2020/12/16, Adaptive Cards 2.5.0 was their latest version
  • We will bump to latest Adaptive Cards (probably 2.9.0) in the next few weeks after we release Web Chat 4.13.0
  • We skipped bumping after 4.12 because 4.12 and 4.13 was too close to each other in terms of release date
    • We don't have time to fully test Adaptive Cards and schedule appropriately if any issues raised

I am curious if it is a bug in Adaptive Cards 2.5.0 and fixed in later versions.

I looked at their schema about Action.Submit and associatedInputs, the associateInputs property was introduced in schema 1.3, i.e. is in 2.5.0.

Could you share the Adaptive Cards JSON to us to further investigate the issue? I want to make sure when we bump to >= 2.9.0, it will fix the issue you are seeing.

@eyadon
Copy link
Author

eyadon commented Apr 5, 2021

Thanks for the info, here's the JSON:
{ "type": "AdaptiveCard", "$schema": "http://adaptivecards.io/schemas/adaptive-card.json", "version": "1.3", "body": [ { "type": "Input.Text", "placeholder": "Placeholder text", "label": "Required text input", "isRequired": true, "id": "a", "errorMessage": "Invalid" }, { "type": "Input.Number", "placeholder": "Placeholder text", "id": "b", "label": "Required number input", "isRequired": true, "errorMessage": "Invalid", "min": 5, "max": 8 } ], "actions": [ { "type": "Action.Submit", "title": "Action.Submit with validation" }, { "type": "Action.Submit", "title": "Action.Submit without validation", "associatedInputs": "none" } ] }

@corinagum
Copy link
Contributor

To note, updating Adaptive Cards on Web Chat also requires coordination across several teams which makes 'immediate' bumps fairly difficult. However we're very excited about these new features too!

@corinagum corinagum changed the title Please update to latest version of AdaptiveCards Please update to latest version of AdaptiveCards (schema 1.4, SDK 2.9) Apr 12, 2021
@corinagum
Copy link
Contributor

DDEfromOR kindly provided a bot that already has cards testing new behavior we can 'borrow' for Mock Bot 😁
https://github.com/DDEfromOR/AC2ErrorBot

@corinagum
Copy link
Contributor

Adaptive Cards has been bumped, but action.execute still needs implementation on Web Chat. Closing in favor of #3844

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. feature-request Azure report label
Projects
None yet
Development

No branches or pull requests

4 participants