Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.10.0 Post-release checklist #3428

Closed
7 of 9 tasks
compulim opened this issue Aug 19, 2020 · 2 comments
Closed
7 of 9 tasks

4.10.0 Post-release checklist #3428

compulim opened this issue Aug 19, 2020 · 2 comments
Assignees
Labels
release Release checklist

Comments

@compulim
Copy link
Contributor

compulim commented Aug 19, 2020

These are chores that we should do before starting the cycle to reduce ripple effects if we do it in mid-cycle.

Tips:

  • Clean your repo before start
  • Remove node_modules from all folder
    • git clean -fdx
  • Never delete package-lock.json
  • If you mess it up, tableflip and redo
  • In component/package.json
    • Remove reference to botframework-webchat-core by hand-modifying package.json
    • Then, npm install (symlinks will be broken afterward)
    • Then, add those references back by hand-modifying package.json
    • This also applies for other packages with similar dependencies/symlinks
    • To build afterward, do tableflip to rebuild those symlinks

Applies to all releases

This list should be copied to versions in the future.

Applies to major/minor releases

Do not applies to patch releases, i.e. 4.10.0 -> 4.10.1.

Bump all dependencies to latest version

On each package.json under root and /packages/:

  • All NPM packages (@babel/*, jest, lerna, typescript, webpack, etc) (#XXX)
    • Don't bump the following packages
      • react, react-dom, redux, redux-saga
        • Locking down for app compatibility
      • remark and strip-markdown
        • Newer remark don't work under IE11
        • Please go to the their repos and see if this is fixed or by design
      • serve
      • rxjs on playground
      • microsoft-cognitiveservices-speech-sdk
  • Run npm audit fix to make sure everything is fixed
  • Test under IE11 to make sure all dependencies are working

Bump Docker image

The Docker image can be found at root docker-compose.yml and Dockerfile*.

  • Docker container for headless Chrome (#XXX)
    • They recently moved from 3.14.159-xxx tag scheme to a more sensible 84.0 tag scheme
    • Tags can be found at https://hub.docker.com/r/selenium/node-chrome/tags
    • Preferably in separate PR because screenshots change can be large occasionally
    • Run tests locally, as the screenshots can be slightly different

Additional steps for 4.10.0

  • Clean up branches on official repo
    • We should only have these branches:
      • master (or main)
      • gh-pages
      • ibiza
      • preview-* (this is for private preview of features)
      • qfe*
      • v3
    • For 4.10.0 only: please keep v0.15.0 and investigate later, I am unsure who created this and why it is there.
    • Everyone should fork and submit PR thru their fork
    • Please ping devs who created branches on the official repo about deletion of their branches
@corinagum
Copy link
Contributor

corinagum commented Sep 3, 2020

Partially implemented by PR #3442
We still need:

  • cognitive services
  • Docker image bump

@compulim
Copy link
Contributor Author

We will fix it on post-4.10.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Release checklist
Projects
None yet
Development

No branches or pull requests

2 participants