Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IC3] Activity.attachments[].contentUrl should be used for allowing download attachments or not #2864

Closed
compulim opened this issue Jan 28, 2020 · 0 comments · Fixed by #2868
Closed

[IC3] Activity.attachments[].contentUrl should be used for allowing download attachments or not #2864

compulim opened this issue Jan 28, 2020 · 0 comments · Fixed by #2868
Assignees
@compulim
Labels
external-omnichannel

Comments

@compulim
Copy link
Contributor

Feature Request

Some channels allow end-users to download their uploaded files.

Designs

Using activity.attachments[].contentUrl to filter

Today:

  • Web Chat will not allow anyone to download any uploaded files
  • Direct Line channel will set "contentUrl" to a dummy URL

Tomorrow:

  • Web Chat Redux store will have a helper to filter out the dummy URL from Direct Line, and set contentUrl to empty
  • Web Chat will allow anyone to download any uploaded files, if the channel support it
    • activity.attachments[].contentUrl would be set to something other than falsy

[Enhancement]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
external-omnichannel
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Show download link and icon based on contentUrl compulim/BotFramework-WebChat
1 participant
@compulim