Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make build scripts better #2748

Closed
7 tasks done
compulim opened this issue Dec 17, 2019 · 0 comments · Fixed by #2767
Closed
7 tasks done

Make build scripts better #2748

compulim opened this issue Dec 17, 2019 · 0 comments · Fixed by #2767
Assignees
@compulim

Comments

@compulim
Copy link
Contributor

compulim commented Dec 17, 2019 •
edited
Loading

Feature Request

❓ = needs investigation

Implementations

Make build scripts simpler

  • npm start will do development build + watch
  • npm run prepublishOnly will do production build
  • npm test will run Jest + watch
  • npm tableflip will run stuff from NPX

Development build

  • Leave node_dev as-is (undefined)
    • When running on VSTS, npm test should run cross-env node_dev=test npm test --coverage true --no-watch
  • Setup source map correctly, so can debug easily in browser

Lerna

  • Remove samples from lerna.json
    • We no longer symlink packages/* to create-react-app samples
    • We can run npm ci manually when we build the sample
  • Remove embed from lerna.json
  • Update CONTRIBUTING.md

[Enhancement]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset build script compulim/BotFramework-WebChat
1 participant
@compulim