Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test reliability: useScrollToEnd.js #2653

Closed
compulim opened this issue Dec 3, 2019 · 0 comments · Fixed by #2777
Closed

Test reliability: useScrollToEnd.js #2653

compulim opened this issue Dec 3, 2019 · 0 comments · Fixed by #2777
Assignees
@compulim

Comments

@compulim
Copy link
Contributor

compulim commented Dec 3, 2019 •
edited
Loading

Feature Request

Improves test reliability for useScrollToEnd.js test "calling scrollToEnd should scroll to end".

The highlighted line is timing out.

It could be because scrollToBottomCompleted condition check is not effective if it is running immediately after the activity is being shown.

image

[Enhancement]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve test reliability compulim/BotFramework-WebChat
1 participant
@compulim