Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Playground is not loading because of dependencies problem with React #2583

Closed
compulim opened this issue Nov 11, 2019 · 0 comments · Fixed by #2584
Closed

Playground is not loading because of dependencies problem with React #2583

compulim opened this issue Nov 11, 2019 · 0 comments · Fixed by #2584
Assignees
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Version

4.6.0 (master)

Describe the bug

This bug only affect users who "npm install" Web Chat with devDependencies, e.g. playground or any packages that use npm link or lerna to include Web Chat in their build.

When botframework-webchat is installed with devDependencies, it installed React 0.14.9 due to transient dependencies from webpack-visualizer plugin.

botframework-webchat do not include devDependencies of React 16.8.6. This is because of the "Rules of Hooks" to maintain a single instance of React. We do include React 16.8.6 at the root package, so both playground and botframework-webchat-* will share the same instance of React.

To Reproduce

Steps to reproduce the behavior:

  1. Clone the repository
  2. Build
  3. Run playground
  4. Type help

Expected behavior

A list of commands are shown.

Instead, console log say thumbnailCard is having issues with React.useMemo.

Additional context

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Nov 11, 2019
@tdurnford tdurnford removed Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-reported Required for internal Azure reporting. Do not delete. labels Nov 11, 2019
@corinagum corinagum removed the Pending label Nov 11, 2019
@corinagum corinagum mentioned this issue Dec 13, 2019
73 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants