Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microphone button disabled when speech synthesis is disabled and received an "expecting" input hint #2435

Closed
compulim opened this issue Oct 2, 2019 · 0 comments · Fixed by #2445
Assignees
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.

Comments

@compulim
Copy link
Contributor

compulim commented Oct 2, 2019

Screenshots

image

Version

master

Describe the bug

When speech synthesis is disabled, but speech recognition is enabled (i.e. sample 06.h), the microphone button is disabled after receiving an "expecting" input hint.

To Reproduce

  1. Run sample 06.h
  2. Say, "input hint expected"

Expected behavior

After receiving the message "This activity is expecting input", the microphone should be re-opened to receive further speech commands from the user.

Additional context

Looks like the expecting input is trying to open the microphone, but somehow it stuck at "opening (1)" phase.

image

When we are investigating, the "expecting input" saga is trying to turn on the microphone by calling startDictate. This will open microphone after all synthesis is completed, which never happen. But if we call stopSpeakingActivity, it will never speak any activities if speech synthesis is not disabled.

Looks like the best fix would be, instead of ignoring the speech synthesis engine, we should provide a "no-op" speech synthesis engine.

If the dev did not provide a speech synthesis engine, the "no-op" engine will pretend to synthesize the activity and signal the completion synchronously. In this way, the expecting input should continue to work.

[Bug]

@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending customer-reported Required for internal Azure reporting. Do not delete. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. labels Oct 2, 2019
@compulim compulim mentioned this issue Oct 25, 2019
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bot Services Required for internal Azure reporting. Do not delete. Do not change color. bug Indicates an unexpected problem or an unintended behavior. customer-reported Required for internal Azure reporting. Do not delete.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant