Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectivity status should not waste-render every 400ms #2418

Closed
compulim opened this issue Sep 22, 2019 · 0 comments · Fixed by #2419
Closed

Connectivity status should not waste-render every 400ms #2418

compulim opened this issue Sep 22, 2019 · 0 comments · Fixed by #2419
Assignees
@compulim
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@compulim
Copy link
Contributor

Version

master

Describe the bug

When putting a console.log() inside the render function of DebouncedConnectivityStatus, it was called every 400 ms due to wasted render.

To Reproduce

As described in the above section.

Expected behavior

It should only render when changed.

Additional context

This is caused by recent React functional component push.

[Bug]
@compulim compulim added bug Indicates an unexpected problem or an unintended behavior. Pending labels Sep 22, 2019
@compulim compulim mentioned this issue Sep 22, 2019
Merged
1 task
@compulim compulim mentioned this issue Oct 25, 2019
Closed
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@compulim compulim

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix waste render on connectivity status compulim/BotFramework-WebChat
1 participant
@compulim