Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to functional components with React Hooks #1818

Closed
Tosters opened this issue Mar 18, 2019 · 4 comments · Fixed by #2322
Closed

Move to functional components with React Hooks #1818

Tosters opened this issue Mar 18, 2019 · 4 comments · Fixed by #2322
Assignees
Labels
front-burner needs-repro Waiting for repro or investigation p0 Must Fix. Release-blocker

Comments

@Tosters
Copy link

Tosters commented Mar 18, 2019

Hi,
This is not really an issues, but is there any info on if there are plans to add react 17.0.0 dependency to webchat? As some of the lifecycle methods will be removed from react 17?
Thanks.

@corinagum
Copy link
Contributor

Thanks for bringing this up! Update on Async Rendering

We actually have a note for this already in our code: BasicWebChat.js but we can use this issue to track the topic as the team discusses it.

I did some research but haven't yet found a projected release date for React 17. However, componentWillMount, componentWillReceiveProps, and componentWillUpdate have already been introduced as 'unsafe' as of React 16.3.

@corinagum corinagum added Pending needs-repro Waiting for repro or investigation labels Mar 18, 2019
@corinagum corinagum changed the title WebChat react versions future Remove (to be) deprecated React lifecycle methods Mar 18, 2019
@Tosters
Copy link
Author

Tosters commented Mar 18, 2019

Hey, thanks for the reply.
I didn't quite understand if webchat itself will have dependency on react v17 (whenever it might be).
As it sounds more logical that you would follow react updates and won't stay on the 16.x.x version forever.

@corinagum
Copy link
Contributor

We can do this at the same time we bump to React 17. :)

@corinagum corinagum added backlog Out of scope for the current iteration but it will be evaluated in a future release. front-burner and removed Triage-E labels Mar 19, 2019
@corinagum corinagum self-assigned this Jul 10, 2019
@corinagum corinagum added 4.6 p0 Must Fix. Release-blocker and removed backlog Out of scope for the current iteration but it will be evaluated in a future release. labels Jul 10, 2019
@compulim compulim changed the title Remove (to be) deprecated React lifecycle methods Move to functional components with React Hooks Jul 12, 2019
@Kaiqb Kaiqb added the Customer label Jul 23, 2019
@corinagum
Copy link
Contributor

corinagum commented Jul 30, 2019

Component name Class Legacy lifecycle No lifecycle Hooked
AdaptiveCardAttachments ✔️ ✔️ ✔️
AnimationCardAttachments ✔️ ✔️ ✔️
CommonCard ✔️ ✔️ ✔️
HeroCardAttachment ✔️ ✔️ ✔️
OAuthCardAttachment ✔️ ✔️ ✔️
ReceiptCardAttachment ✔️ ✔️ ✔️
ThumbnailCardAttachment ✔️ ✔️ ✔️
FullReactWebChat ✔️
BasicWebChat ✔️ ✔️
Composer ✔️ ✔️
Dictation ✔️ ✔️ ✔️
ConnectivityStatus ✔️
UploadButton ✔️ ✔️ ✔️
CroppedImage ✔️ ✔️ ✔️
RelativeTime ✔️ ✔️
Timer ✔️ ✔️
Box ✔️ ✔️
App.js (Playground) ✔️
JSONDebugView ✔️ ✔️ ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
front-burner needs-repro Waiting for repro or investigation p0 Must Fix. Release-blocker
Projects
None yet
5 participants