From 1287624143404dc154c137c97ff622d4bfc1d9a0 Mon Sep 17 00:00:00 2001 From: William Wong Date: Thu, 16 Jun 2022 16:03:59 -0700 Subject: [PATCH] Incorp PR changes --- packages/component/src/LiveRegion/LiveRegionActivity.tsx | 2 +- .../component/src/LiveRegion/private/LiveRegionAttachments.tsx | 2 +- packages/component/src/SendBox/SuggestedActions.tsx | 2 +- packages/component/src/Transcript/LiveRegionTranscript.tsx | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/component/src/LiveRegion/LiveRegionActivity.tsx b/packages/component/src/LiveRegion/LiveRegionActivity.tsx index 8f8ba8d9be..ceb65845a1 100644 --- a/packages/component/src/LiveRegion/LiveRegionActivity.tsx +++ b/packages/component/src/LiveRegion/LiveRegionActivity.tsx @@ -66,7 +66,7 @@ const LiveRegionActivity: VFC = ({ activity, id }) => { return activityKey && `webchat__live-region-activity__label-${activityKey}`; }, [activity, getKeyByActivity]); - // TODO: [P0] Investigate: this section seems to be narrated 2 times by some screen readers. + // TODO: [P0] #4294 Investigate: this section seems to be narrated 2 times by some screen readers. return (
= ({ activity }) => const attachmentForScreenReaderRenderers = attachments .map(attachment => createAttachmentForScreenReaderRenderer({ activity, attachment })) - .filter(render => render); + .filter(Boolean); const numGenericAttachments = attachments.length - attachmentForScreenReaderRenderers.length; diff --git a/packages/component/src/SendBox/SuggestedActions.tsx b/packages/component/src/SendBox/SuggestedActions.tsx index 49f075351a..d7cca5a27f 100644 --- a/packages/component/src/SendBox/SuggestedActions.tsx +++ b/packages/component/src/SendBox/SuggestedActions.tsx @@ -214,7 +214,7 @@ const SuggestedActions: FC = ({ className, suggestedActio const [{ suggestedActionLayout, suggestedActionsStackedLayoutButtonTextWrap }] = useStyleOptions(); const localize = useLocalizer(); - // TODO: [P1] Clean up this one so screen reader will narrate something similar to "suggested actions toolbar". + // TODO: [P1] #4315 Clean up this one so screen reader will narrate something similar to "suggested actions toolbar". const screenReaderText = localize('SUGGESTED_ACTIONS_ALT', ''); const children = suggestedActions.map((cardAction, index) => { diff --git a/packages/component/src/Transcript/LiveRegionTranscript.tsx b/packages/component/src/Transcript/LiveRegionTranscript.tsx index 2a2c4254f9..edb57fb070 100644 --- a/packages/component/src/Transcript/LiveRegionTranscript.tsx +++ b/packages/component/src/Transcript/LiveRegionTranscript.tsx @@ -90,7 +90,7 @@ const LiveRegionTranscriptCore: FC = ({ activityE typistNames[0] ); - // TODO: [P*] We should change the narration to "Message has suggested actions. Press SHIFT + ALT + A to select them." + // TODO: [P1] #4315 We should change the narration to "Message has suggested actions. Press SHIFT + ALT + A to select them." const liveRegionSuggestedActionsLabelAlt = localize( 'SUGGESTED_ACTIONS_ALT', accessKey