Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emulator UI: Bot Setting modal should disable key field when not checked #832

Closed
mewa1024 opened this issue Sep 6, 2018 · 5 comments
Closed
Assignees
Labels
Approved Approved by the Triage team Bug Your classic code defect Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P1 Painful if we don't fix, won't block releasing

Comments

@mewa1024
Copy link

mewa1024 commented Sep 6, 2018

Version windows 4.0.0-preview-.39773 (released 9/20 ~3AM)

In the Bot Settings modal, when encryption is not selected, the section below the checkbox should be disabled and grayed out and the placeholder text should appear. It looks like this:

image

but it should look like this:
image

Screen is here: https://microsoft-fuse-design.invisionapp.com/d/main#/console/15183213/320119845/preview
Comp of encryption flow is here: https://microsoft-fuse-design.invisionapp.com/d/main#/projects/prototypes/15183213

Please note that we are changing the field label of "Key" to "Secret" and "Generate new key" to "Generate new password".

@mewa1024 mewa1024 added the Bug Your classic code defect label Sep 6, 2018
@vishwacsena vishwacsena added Approved Approved by the Triage team Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P1 Painful if we don't fix, won't block releasing labels Sep 6, 2018
@mewa1024
Copy link
Author

Also, please change "Reset" to "Generate new key" (bug #870).

@mewa1024
Copy link
Author

Also, please don't use ellipsis so users can select into the overflow text to view it.

@mewa1024
Copy link
Author

@mewa1024
Copy link
Author

Updated comp to change the field label of "Key" to "Secret" and "Generate new key" to "Generate new password".

@tonyanziano
Copy link
Contributor

This is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Approved Approved by the Triage team Bug Your classic code defect Next-Iteration An approved issue or bug, in the backlog, that is planned for the next iteration P1 Painful if we don't fix, won't block releasing
Projects
None yet
Development

No branches or pull requests

3 participants