Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Move state store code to /app/shared #2038

Closed
tonyanziano opened this issue Jan 8, 2020 · 0 comments · Fixed by #2060
Closed

[Enhancement] Move state store code to /app/shared #2038

tonyanziano opened this issue Jan 8, 2020 · 0 comments · Fixed by #2060
Assignees
@tonyanziano
Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020

Comments

@tonyanziano
Copy link
Contributor

Currently, the action and reducer code, is duplicated in both /packages/app/client and /packages/app/main.

The number of files here could be halved by moving all this shared code into /packages/app/shared/state where both the main and client code bases could import it from.

The only thing left on either side would be the store initialization code and that side's sagas.
@tonyanziano tonyanziano added P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020 labels Jan 8, 2020
@tonyanziano tonyanziano self-assigned this Jan 8, 2020
@tonyanziano tonyanziano mentioned this issue Jan 24, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tonyanziano tonyanziano

Labels
P1 Painful if we don't fix, won't block releasing R8 Release 8 - March 16th, 2020
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Moved shared store code to app/shared. microsoft/BotFramework-Emulator
1 participant
@tonyanziano