Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Telemetry Compliance] Make auto update opt-in #1408

Closed
tonyanziano opened this issue Apr 2, 2019 · 8 comments · Fixed by #1575
Closed

[Telemetry Compliance] Make auto update opt-in #1408

tonyanziano opened this issue Apr 2, 2019 · 8 comments · Fixed by #1575
Assignees
Labels
Design Design Team issue Enhancement New feature or request to evolve an additional feature T-Shirt: S Half Day

Comments

@tonyanziano
Copy link
Contributor

Change auto update so that it is opt-in by default, and add UI that allows the user to opt-in when an update is detected.

@tonyanziano tonyanziano added 4.5 Enhancement New feature or request to evolve an additional feature T-Shirt: S Half Day labels Apr 2, 2019
@tonyanziano tonyanziano added the Design Design Team issue label May 13, 2019
@mewa1024 mewa1024 self-assigned this May 13, 2019
@mewa1024
Copy link

Let's follow these steps:

  1. User selects Help > Check for updates...

  2. First-time experience, a modal appears with this content (using our usual modal styles):

    Update available
    Bot Framework is available. How would you like to install the update? You will need to restart
    the Emulator after installing.

    ( ) Download and manually install this update.
    ( * ) Install this update and restart the Emulator.
    ( ) Automatically download and install all updates.

    Cancel [ secondary button ] Update [ primary button ]

By default, the middle radio button is selected ("Install this updated and restart the Emulator"). If the user selects the first button and clicks "Update", Emulator will start the download and use the usual modals for progress, examples below copied these screenshots from the v3 migration flow (should be more or less the same):
image
etc.

If the user selects the third button, Emulator will start downloading and installation (with usual modals for progress):
image
image
etc.

The next time they select Help > Check for updates..., Emulator will skip the "Update available" modal and start downloading and installing. To turn off auto-installing updates, the user will need to go to the Settings tab.

@mewa1024 mewa1024 assigned mewa1024 and tonyanziano and unassigned mewa1024 May 14, 2019
@tonyanziano
Copy link
Contributor Author

@mewa1024 Sounds good. The only thing is that we can't really use a modal & progress bar for the "Install" step because that is controlled by the native operating system installer, but the rest should be doable.

I'm currently using the VSCode radio button style for the modal:

image

@mewa1024
Copy link

@tonyanziano cool. Is there a radio button for light theme? I suspect the white dot on gray background won't meet accessibility.

@tonyanziano
Copy link
Contributor Author

tonyanziano commented May 14, 2019

@mewa1024 doesn't look like it:

image

Can we maybe give the unselected radio buttons a thin blue border around the circle?

image

@mewa1024
Copy link

@tonyanziano I chatted with the VS Code designer offline, and VS Code doesn't actually use a radio button anywhere, so they didn't run into the need for a spec on a light background.

So let's use a black border--it's a little closer to MS Fabric's radio: https://developer.microsoft.com/en-us/fabric#/controls/web/choicegroup

@tonyanziano
Copy link
Contributor Author

@mewa1024 so like this?

image

Or would you prefer the original blue fill with a black border?

@mewa1024
Copy link

@tonyanziano Sorry--original blue for the selected but black border for unselected.

@tonyanziano
Copy link
Contributor Author

@mewa1024 roger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design Team issue Enhancement New feature or request to evolve an additional feature T-Shirt: S Half Day
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants