-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Telemetry Compliance] Make auto update opt-in #1408
Comments
@mewa1024 Sounds good. The only thing is that we can't really use a modal & progress bar for the "Install" step because that is controlled by the native operating system installer, but the rest should be doable. I'm currently using the VSCode radio button style for the modal: |
@tonyanziano cool. Is there a radio button for light theme? I suspect the white dot on gray background won't meet accessibility. |
@mewa1024 doesn't look like it: Can we maybe give the unselected radio buttons a thin blue border around the circle? |
@tonyanziano I chatted with the VS Code designer offline, and VS Code doesn't actually use a radio button anywhere, so they didn't run into the need for a spec on a light background. So let's use a black border--it's a little closer to MS Fabric's radio: https://developer.microsoft.com/en-us/fabric#/controls/web/choicegroup |
@mewa1024 so like this? Or would you prefer the original blue fill with a black border? |
@tonyanziano Sorry--original blue for the selected but black border for unselected. |
@mewa1024 roger. |
Change auto update so that it is opt-in by default, and add UI that allows the user to opt-in when an update is detected.
The text was updated successfully, but these errors were encountered: