WebChat tries to render all activity types

[v-kydela]

Version

4.3.0

Describe the bug

The latest Emulator version and a few past versions have been trying to render endOfConversation activities and failing with a sort of error message

To Reproduce

The BotBuilder V3 Node SDK seems to generate endOfConversation activities when the bot encounters an error, though you can probably reproduce this in any SDK by sending your own activity

Expected behavior

The Emulator should not try to render anything but message activities in its conversation panel

Screenshots

Additional context

This is the same as #1328 but with endOfConversation activities instead of trace activities.

[bug]

[pepperakos]

I can also confirm this same behavior... I have 4.3.0 of the bot emulator and had started an Enterprise Bot using the instructions from MS just yesterday.

[cwhitten]

To address this in the near term, the Emulator client will ignore trace and endOfConversation Activity types in the ActivityType middleware

[compulim]

Sample for activity middleware, https://github.com/Microsoft/BotFramework-WebChat/tree/master/samples/10.b.customization-password-input. Just return false for anything we don't want to render.

[corinagum]

@justinwilaby started a Teams conversation where hiding the trace may not be an ideal solution. Reopening this issue for discussion and visibility.

[cwhitten]

For visibility: The plan to address is that in Emulator mode, we don't render trace activity types, in sidecar mode we will, with implemented renderers for the trace, and specifically the debug trace type. What we won't do is render an activity whose type we do not have a renderer for all-up, of which the LUIS trace type, or endOfConversation is an example.

[cwhitten]

this is still addressed in #1363