From b58d796119866fa4d4efcea23797f511294a416c Mon Sep 17 00:00:00 2001 From: Tony Anziano Date: Tue, 27 Aug 2019 11:27:13 -0700 Subject: [PATCH] Fixed color contrast issues on welcome page. --- CHANGELOG.md | 1 + .../src/ui/editor/recentBotsList/recentBotsList.scss | 7 +++++-- .../src/ui/editor/recentBotsList/recentBotsList.scss.d.ts | 2 +- packages/app/client/src/ui/styles/themes/dark.css | 2 +- packages/app/client/src/ui/styles/themes/light.css | 5 +++-- 5 files changed, 11 insertions(+), 6 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index b9bd35fc4..54675680e 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 - [1775](https://github.com/microsoft/BotFramework-Emulator/pull/1775) - [1776](https://github.com/microsoft/BotFramework-Emulator/pull/1776) - [1781](https://github.com/microsoft/BotFramework-Emulator/pull/1781) + - [1782](https://github.com/microsoft/BotFramework-Emulator/pull/1782) ## v4.5.2 - 2019 - 07 - 17 ## Fixed diff --git a/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss b/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss index 4b886aa1e..e90b94027 100644 --- a/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss +++ b/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss @@ -53,6 +53,10 @@ background-color: var(--my-bots-entry-bg); border: var(--my-bots-entry-border); + .recent-bot-path { + color: var(--my-bots-entry-hover-color); + } + .recent-bot-action-bar { display: block; } @@ -93,7 +97,7 @@ width: 0; &:after { - color: var(--tab-icon-color); + color: var(--my-bots-entry-color); content: "\2716"; font-size: 12px; height: 16px; @@ -123,7 +127,6 @@ display: inline-block; line-height: 22px; margin-left: 8px; - opacity: 0.5; user-select: text; } diff --git a/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss.d.ts b/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss.d.ts index 25cc62a5a..7f269ee1d 100644 --- a/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss.d.ts +++ b/packages/app/client/src/ui/editor/recentBotsList/recentBotsList.scss.d.ts @@ -2,8 +2,8 @@ export const marginFix: string; export const noBots: string; export const recentBot: string; +export const recentBotPath: string; export const recentBotActionBar: string; export const recentBotsList: string; -export const recentBotPath: string; export const section: string; export const well: string; diff --git a/packages/app/client/src/ui/styles/themes/dark.css b/packages/app/client/src/ui/styles/themes/dark.css index 9e1eacd89..620e17576 100644 --- a/packages/app/client/src/ui/styles/themes/dark.css +++ b/packages/app/client/src/ui/styles/themes/dark.css @@ -183,7 +183,7 @@ html { /* Welcome page */ --welcome-page-bg: var(--tab-active-tab-bg); - --welcome-page-ver: var(--neutral-8); + --welcome-page-ver: var(--neutral-6); --welcome-how-to-border: var(--neutral-6); --welcome-how-to-test: var(--p-button-bg); --welcome-beta-label: var(--warning-outline); diff --git a/packages/app/client/src/ui/styles/themes/light.css b/packages/app/client/src/ui/styles/themes/light.css index 30cab9c0d..9540247e5 100644 --- a/packages/app/client/src/ui/styles/themes/light.css +++ b/packages/app/client/src/ui/styles/themes/light.css @@ -182,7 +182,7 @@ html { /* Welcome page */ --welcome-page-bg: var(--tab-active-tab-bg); - --welcome-page-ver: var(--neutral-8); + --welcome-page-ver: #717171; --welcome-how-to-border: var(--neutral-6); --welcome-how-to-test: var(--p-button-bg); --welcome-beta-label: var(--warning-outline); @@ -191,7 +191,8 @@ html { --my-bots-entry-bg: var(--neutral-4); --my-bots-entry-border: 1px solid transparent; --my-bots-entry-color: var(--neutral-12); - --my-bots-path-color: var(--neutral-12); + --my-bots-path-color: var(--neutral-10); + --my-bots-path-hover-color: var(--neutral-11); --my-bots-scrollbar-color: rgba(136, 136, 136, 0.5); /* Status Bar */