Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utterance is not passed to skill if disambiguation kicks in at parent #6431

Closed
scheyal opened this issue Feb 17, 2021 · 5 comments · Fixed by #7004
Closed

Utterance is not passed to skill if disambiguation kicks in at parent #6431

scheyal opened this issue Feb 17, 2021 · 5 comments · Fixed by #7004
Assignees
Labels
Area: SDK BF SDK issues Multi-bot management P0 Must Fix. Release-blocker Type: Bug Something isn't working
Milestone

Comments

@scheyal
Copy link
Contributor

scheyal commented Feb 17, 2021

Filed for tracking (along with conversation)

Before I file it, I want to make sure I got it right.

Scenario:
• Root bot with Orchestrator
• Child bot with LUIS
• Routing works correctly.
• Without disambiguation child get’s utterance (turn.text?) and is able to trigger on it.
• Issue: With disambiguation: I suspect that utterance is not passed to skill, so skill cannot trigger on recognition.

Failure case (with disambiguation):

pic1

Repeated without disambiguation:

pic2

@scheyal
Copy link
Contributor Author

scheyal commented Feb 18, 2021

Issue is that turn.activity.text is wiped during disambiguation chooseIntent trigger.
I thought it should be the role of the disambiguation trigger to store/restore it. Or at least document in some troubleshooting area?

The fix is to store/restore it such as below:

pic1

@cleemullins cleemullins transferred this issue from microsoft/botframework-components Mar 16, 2021
@ryanisgrig ryanisgrig added Type: Bug Something isn't working Area: SDK BF SDK issues Multi-bot management Needs-triage A new issue that require triage labels Mar 16, 2021
@ryanisgrig
Copy link

Added tags, I'm assuming that the dialog provided when adding the Microsoft.OnChooseIntent trigger is provided by the SDK (having difficulty tracking down it's source).

@cwhitten
Copy link
Member

@cleemullins @ryanlengel why was this transferred to the Composer project? Seems like it should to go the SDK

@cwhitten cwhitten removed the Needs-triage A new issue that require triage label Mar 18, 2021
@scheyal
Copy link
Contributor Author

scheyal commented Mar 18, 2021

@cwhitten (I asked.)

The issue is in the specific choose intent trigger flow in Composer. It loses the turn.activity.text, hence I needed to modify the intent to cache it & use it later. I think the solution is to fix the choose intent flow in Composer.

@peterinnesmsft peterinnesmsft added the P0 Must Fix. Release-blocker label Mar 22, 2021
@ryanisgrig
Copy link

@cwhitten, this is feedback for the predefined dialog that Composer adds in the dialogFactory.ts. I'm not sure what area to label this under, assigning to you for triage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SDK BF SDK issues Multi-bot management P0 Must Fix. Release-blocker Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants