Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LUIS returns 404 error when used through recognizer #5622

Closed
benbrown opened this issue Jan 26, 2021 · 4 comments · Fixed by #5639
Closed

LUIS returns 404 error when used through recognizer #5622

benbrown opened this issue Jan 26, 2021 · 4 comments · Fixed by #5639
Assignees
Labels
Area: LU Belongs to LU feature area P0 Must Fix. Release-blocker

Comments

@benbrown
Copy link
Contributor

Describe the bug

Publishing to LUIS or something about the LUIS recognizer has broken recently. In the nightly build, publishing to LUIS results in a bot that returns a 404 error whenever it consults a LUIS model --- though the publish seems to work as expected.

Attached below are a screenshot of the request and response from the LUIS recognizer call.

Version

Currently nightly build

To Reproduce

Steps to reproduce the behavior:

  1. Create a new bot based on the luis todo template
  2. Set your luis key and region
  3. Start the bot
  4. Open in emulator and type any message
  5. LUIS will return a 404 error, and the bot will say:

"Response status code does not indicate success: 404 (Not Found)."

Screenshots

Screen Shot 2021-01-26 at 3 54 14 PM
Screen Shot 2021-01-26 at 3 54 55 PM
Screen Shot 2021-01-26 at 3 55 01 PM

@luhan2017
Copy link
Contributor

luhan2017 commented Jan 27, 2021

I did some investigation and found there are several factors causing this issue.

  1. There is a bug fix in the SDK in Dec 2, Which fixes the issue The LuisAdaptiveRecognizer does not read (in particularly, via expression) the version info correctly. Here is the commit microsoft/botbuilder-dotnet@3af7b7b
  2. Luis's version API is broken, I got 404 error when call luis API with the right version parameter. https://westus.dev.cognitive.microsoft.com/docs/services/luis-endpoint-api-v3-0/operations/5cb0a9459a1fe8fa44c28dd8, I already initiated an email thread with Luis PMs on this.
  3. There is a commit to update the composer runtime to R12 daily bits.

So the overall story is that, previously SDK has a bug to read the luis version info, even though the Luis API is broken(I don't know if it ever works), so that the luis recognizers works fine in both composer and sdk. and then the version bug is fixed in the sdk, and we brought daily bits in in composer, so that the composer nightly had been broken.

The follow ups:

  1. switch back from daily bits to released bits. I don't see the benefit of bringing in daily bits to composer, every time we update the runtime packages we should sign off in the composer side, otherwise it is quite easy to break and hard to debug if the root cause is from composer or sdk. So I strongly suggest we just keep the stable version.
  2. Push luis team to fix their API with version parameter, or ask them the right format and update accordingly in the sdk side.

@benbrown @cwhitten and @pavolumMsft for your awareness.

@boydc2014 boydc2014 transferred this issue from microsoft/BotFramework-Composer Jan 27, 2021
@boydc2014 boydc2014 assigned luhan2017 and unassigned luhan2017 Jan 27, 2021
@boydc2014
Copy link
Contributor

@luhan2017 thanks for the investigation, so this means in the current SDK bits, the LUIS recognizer is broken when you have version field exists, right?

This sounds like a P0 bug we have to fix. Transferring this to SDK repo for awareness.

@boydc2014 boydc2014 transferred this issue from microsoft/botbuilder-dotnet Jan 27, 2021
@cleemullins cleemullins added Area: LU Belongs to LU feature area P0 Must Fix. Release-blocker labels Jan 27, 2021
@chrimc62
Copy link
Contributor

chrimc62 commented Jan 27, 2021

It is exactly these kinds of issues that are caught by having composer dailies use the latest SDK. Otherwise we end up with a scramble at the end when the composer or SDK have a bug or mismatch. For example, there are some bug fixes in the form generation SDK runtime. If composer does not have the latest bits, people will report issues that have been fixed for months. I verified the LUIS version works with the current recognizer. If there is an issue it is likely in Composer publishing.

@luhan2017
Copy link
Contributor

@zidaneymar We should support the directVersionPublish for the deployment script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: LU Belongs to LU feature area P0 Must Fix. Release-blocker
Projects
None yet
6 participants